Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redundant selectors in normalize #331

Merged
merged 5 commits into from Jan 10, 2023
Merged

Fix redundant selectors in normalize #331

merged 5 commits into from Jan 10, 2023

Conversation

jacobrask
Copy link
Contributor

@jacobrask jacobrask commented Jan 7, 2023 •
edited

Preparing a fork/variant of the "extra" styles and found some redundant selectors.

  • Redundant element selectors in input:not() (input cannot also be button)
  • Redundant [type] in :where(button,button[type]) - has no effect since both selectors have 0 specificity
  • Redundant nesting in svg:not([width])

@stackblitz
Copy link

stackblitz bot commented Jan 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

argyleink
argyleink approved these changes Jan 10, 2023
View reviewed changes
Copy link
Owner

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rad, thanks for the PR and the attention to detail 👍🏻

@argyleink argyleink merged commit b910bd5 into argyleink:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argyleink argyleink argyleink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacobrask @argyleink