Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playerクラスへjoin/disconnect処理を移行したい #58

Open
mnsinri opened this issue May 11, 2023 · 2 comments
Open

Playerクラスへjoin/disconnect処理を移行したい #58

mnsinri opened this issue May 11, 2023 · 2 comments
Assignees
@mnsinri
Labels
enhancement New feature or request

Comments

@mnsinri
Copy link
Contributor

mnsinri commented May 11, 2023

お気持ちの問題ですが、
（auto disconnectはclass Player側でやる予定なので）class Zundacordからclass Playerに、vcへのjoin/disconnect処理を移動させたくないでしょうか。
@sarisia
Copy link
Member

sarisia commented May 11, 2023

わかる いいと思う

@mnsinri mnsinri self-assigned this May 11, 2023
@sarisia sarisia added the enhancement New feature or request label May 11, 2023
@sarisia
Copy link
Member

sarisia commented May 11, 2023

ちなみに, 確信はないけど #55 と #53 の切断時に恐らく App.guildPlayers からプレイヤーが削除されてないんだよね. これも一緒に修正する必要がありそう

@mnsinri mnsinri mentioned this issue May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnsinri mnsinri

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sarisia @mnsinri