Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add purge command #55

Merged
merged 8 commits into from
May 11, 2023
Merged

Feature add purge command #55

merged 8 commits into from
May 11, 2023

Conversation

ma1750
Copy link
Member

@ma1750 ma1750 commented May 9, 2023

Resolved #52

コマンド名は/purgeにしました.
image

@ma1750 ma1750 added the enhancement New feature or request label May 9, 2023
@ma1750 ma1750 self-assigned this May 9, 2023
@ma1750 ma1750 requested a review from sarisia as a code owner May 9, 2023 16:03
Copy link
Member

@sarisia sarisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/disconnect でお願いします!後出しでごめん

@ma1750
Copy link
Member Author

ma1750 commented May 10, 2023

/disconnect に変更しました.

@ma1750 ma1750 requested a review from sarisia May 10, 2023 14:16
src/zundacord/app.ts Outdated Show resolved Hide resolved
src/zundacord/app.ts Outdated Show resolved Hide resolved
Comment on lines 357 to 359
.setTitle("Unhandled error")
.setDescription(`Contact admin. ${e}`)
}
Copy link
Member

@sarisia sarisia May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

show this as internal error, like:

.setTitle("Internal error")
.setDescription("Try again later")
]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大丈夫そうなら resolve してほしい

@ma1750 ma1750 requested a review from sarisia May 10, 2023 15:01
@sarisia sarisia enabled auto-merge (squash) May 11, 2023 16:45
ma1750 and others added 8 commits May 12, 2023 01:46
try-catch の使い方が分からない.`doPurge`の中身をアトミックにやりたい.User名が数字になるのをいい感じにする.
Co-authored-by: Takakazu Fu <git@sarisia.cc>
Co-authored-by: Takakazu Fu <git@sarisia.cc>
@sarisia sarisia force-pushed the feature-add-purge-command branch from e7c4668 to 3cd5286 Compare May 11, 2023 16:46
@sarisia sarisia merged commit e01d460 into main May 11, 2023
@sarisia sarisia deleted the feature-add-purge-command branch May 11, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

botをVCから退出させる方法が提供されていない
2 participants