Add topoapi check + cleanup netrc check #47
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
ReviewNB is not working correctly. Did you just add the block at the top for inputting netrc / opentopo credentials? |
|
@sssangha when the notebook asks for username and password both are visible as we enter them. Is this something we may want to avoid? It isn't really that big of a deal probably but just wanted to point out. Also when committing notebooks, it may be a good idea to "clear outputs" which would shrink the size of the notebook and make it faster to checkout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add topoapi check + cleanup .netrc checks and move all to prep stage(s) at top of notebook.
If a given file doesn't exist, and explicit warning is passed, plus a prompt for users to enter their credentials.