ARIA Download NISAR GUNWs

[bbuzz31]

add download support for NISAR GUNWs

[alexfore]

I added some questions and a few style points

[alexfore]

misalignment

[bbuzz31]

not sure what it's supposed to be

[alexfore]

The llines are not aligned correctly

[alexfore]

    dct_kw = dict(dataset='ARIA S1 GUNW',
                    processingLevel=asf_search.constants.GUNW_STD,

dataset and processingLevel should be aligned on subsequent lines

[alexfore]

I've asked repeatedly for you to pay attention to the style of the code which you are committing. You have not done that so far. Please look at what you have done and ask yourself:

• Is what I have committed PEP8 compliant?
• Is the use of whitespace consistent with the rest of the code in this module?
• Is what I have committed improving the software or adding more issues that need to be fixed in the future? (technical debt)

I think that style is extremely important. From my point of view imposing style requirements on this code base is the first step to making it a maintainable code base. If the main developers on this project do not agree I will not be able to help

It will be worth your time to memorize everything here: https://peps.python.org/pep-0008/

[bbuzz31]

I implemented all your requested changes. If you have more requests, point them out.

[jhkennedy]

I've asked repeatedly for you to pay attention to the style of the code which you are committing. You have not done that so far. Please look at what you have done and ask yourself:

* Is what I have committed PEP8 compliant?

* Is the use of whitespace consistent with the rest of the code in this module?

* Is what I have committed improving the software or adding more issues that need to be fixed in the future? (technical debt)

I think that style is extremely important. From my point of view imposing style requirements on this code base is the first step to making it a maintainable code base. If the main developers on this project do not agree I will not be able to help

It will be worth your time to memorize everything here: https://peps.python.org/pep-0008/

@alexfore, there seems to be a lot of unnecessary back and forth related to this that should be handled by CI/CD linting checks -- it's much better for everyone involved for a bot to be the arbiter.

I suggest spending the effort on setting up a github action for flake8/pylint/ruff.

[alexfore]

I would also love to integrate automated pep8 checks -- because I never want to have this conversation again. I do not like telling people that their code style is messy or inadequate, this clearly leads to conflict.

However, the fact remains that this PR has still contains pep8 violations -- whitespace and alignment. My comments above still stand and I want to see them addressed before I will approve this PR. If someone is unwilling to improve I do not know what to say to that. Maybe use pylint, pycodestyle, or flake8 and try to learn what the issues are. Me telling you or doing it myself is not going to help other people learn.

On my end I will figure out how to integrate the style checks I want in another PR.

[dbekaert]

Hi @alexfore @jhkennedy I like the idea of a bot doing these sort of checks. I think they might even come with suggested fixes etc. Lets add that support in an upcoming PR and perhaps we can let the code-base run through it?

I would like to get the stable test suite in place, the dependency issue fixed for stability. This will allow to check against changes and see if something breaks. With that in place we could route the code through the both for suggested changes?

[alexfore]

I am going to close this PR. We can open a new PR for this branch once I've integrated pep8 auto checks into this repo, and the author has addressed the issues raised by those checks.

[pep8speaks]

Hello @bbuzz31! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file tools/bin/ariaDownload.py:

Line 36:80: E501 line too long (80 > 79 characters)
Line 37:22: E131 continuation line unaligned for hanging indent
Line 41:80: E501 line too long (89 > 79 characters)
Line 318:9: E266 too many leading '#' for block comment
Line 318:9: E303 too many blank lines (2)
Line 320:12: E221 multiple spaces before operator
Line 324:29: E127 continuation line over-indented for visual indent
Line 325:29: E127 continuation line over-indented for visual indent
Line 326:29: E127 continuation line over-indented for visual indent
Line 327:29: E127 continuation line over-indented for visual indent
Line 328:29: E127 continuation line over-indented for visual indent
Line 329:29: E127 continuation line over-indented for visual indent
Line 330:13: E124 closing bracket does not match visual indentation
Line 331:29: E116 unexpected indentation (comment)
Line 338:13: E266 too many leading '#' for block comment
Line 341:29: E126 continuation line over-indented for hanging indent
Line 349:25: E126 continuation line over-indented for hanging indent
Line 351:27: E225 missing whitespace around operator

[alexfore]

This PR needs to be abandoned. These code changes need to start from the dev branch after I've merged dev_refactor.