Skip to content

Fix scoping in the Composite context #7564

Fix scoping in the Composite context

Fix scoping in the Composite context #7564

Triggered via pull request May 21, 2024 05:07
Status Success
Total duration 10m 25s
Artifacts

main.yml

on: pull_request
Install node modules
21s
Install node modules
Matrix: react17
Matrix: test
Matrix: test-chrome
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 2 notices
Build packages
Property 'toHaveFocus' does not exist on type 'Assertion<HTMLElement | null>'.
Build packages
Property 'toHaveFocus' does not exist on type 'Assertion<HTMLElement>'.
[safari] › examples/select-combobox-tab/test-browser.ts:13:3 › Select with Combobox and Tab - reset scroll position when switching tabs: examples/select-combobox-tab/test-browser.ts#L28
2) [safari] › examples/select-combobox-tab/test-browser.ts:13:3 › Select with Combobox and Tab - reset scroll position when switching tabs Error: Timed out 5000ms waiting for expect(locator).not.toBeVisible() Locator: getByRole('dialog') Expected: not visible Received: visible Call log: - expect.not.toBeVisible with timeout 5000ms - waiting for getByRole('dialog') - locator resolved to <div id=":r0:" role="dialog" tabindex="-1" data-dialo…>…</div> - unexpected value "visible" - locator resolved to <div id=":r0:" role="dialog" tabindex="-1" data-dialo…>…</div> - unexpected value "visible" - locator resolved to <div id=":r0:" role="dialog" tabindex="-1" data-dialo…>…</div> - unexpected value "visible" - locator resolved to <div id=":r0:" role="dialog" tabindex="-1" data-dialo…>…</div> - unexpected value "visible" - locator resolved to <div id=":r0:" role="dialog" tabindex="-1" data-dialo…>…</div> - unexpected value "visible" - locator resolved to <div id=":r0:" role="dialog" tabindex="-1" data-dialo…>…</div> - unexpected value "visible" - locator resolved to <div id=":r0:" role="dialog" tabindex="-1" data-dialo…>…</div> - unexpected value "visible" - locator resolved to <div id=":r0:" role="dialog" tabindex="-1" data-dialo…>…</div> - unexpected value "visible" 26 | // Select one of the options at the bottom 27 | await q.option().last().click(); > 28 | await expect(q.dialog()).not.toBeVisible(); | ^ 29 | 30 | // Assert last option is selected and visible in the viewport 31 | await page.keyboard.press("ArrowDown"); at /Users/runner/work/ariakit/ariakit/examples/select-combobox-tab/test-browser.ts:28:34
🎭 Playwright Run Summary
1 flaky [chrome] › examples/composite-menus/test-browser.ts:7:1 › keyboard interactions ──────────────── 157 passed (1.5m)
🎭 Playwright Run Summary
2 flaky [safari] › examples/composite-menus/test-browser.ts:7:1 › keyboard interactions ──────────────── [safari] › examples/select-combobox-tab/test-browser.ts:13:3 › Select with Combobox and Tab - reset scroll position when switching tabs 103 passed (4.4m)