-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some components don't render the passed id prop #518
Comments
Hey @namjul 👋, Thank you for opening an issue. We'll get back to you as soon as we can. If you use Reakit at work, you can also ask your company to sponsor us ❤️. |
Hi @namjul! I can't reproduce it. If I set |
I accidentaly did not provided the correct codesandbox link. |
Thanks for the reproduction! The problem there is that you're setting an invalid id ( The code is throwing on this line: This will throw on any website: We could avoid throwing that by wrapping that part of the code within |
Ah true :) To my situation. I have written a custom singel test based on https://github.com/diegohaz/singel. |
Not sure if I got it. Which example you're referring to? |
If you open the devtools and check the dom elements of each rendered component. Each one should render the |
I see! So, what’s the issue? |
Shouldn't it output the the |
Oh, now I get what you're saying! |
The #520 works know for us. Thank you! |
🐛 Bug report
Current behavior
I used the codesandbox link from https://github.com/reakit/reakit/blob/master/README.md and tested a situation i discovered when using the
id
attribute in combination with components that use theHidden
component.The moment i declare an
id
, it failes to render.Steps to reproduce the bug
Provide a repo or sandbox with the bug and describe the steps to reproduce it.
id
attribute forHidden
or any other component depending on it.Expected behavior
Should render without failure.
Possible solutions
I currently do not have an propper understanding of the new
Id
component and how it works to soi cannot give a possible solution.
Environment
Please, run the command below inside your project directory.
The text was updated successfully, but these errors were encountered: