Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips need to follow wcag 1.4.13 - allow hovering over tooltip #887

Closed
samsch opened this issue Jul 6, 2021 · 7 comments 路 Fixed by #2279
Closed

Tooltips need to follow wcag 1.4.13 - allow hovering over tooltip #887

samsch opened this issue Jul 6, 2021 · 7 comments 路 Fixed by #2279
Labels

Comments

@samsch
Copy link

samsch commented Jul 6, 2021

馃悰 Bug report

The tooltip component needs to default to allowing the user to hover over the popup without it being dismissed.

https://www.w3.org/WAI/WCAG21/Understanding/content-on-hover-or-focus.html

Current behavior

Currently, when you attempt to hover over the pop up, it disappears (as you are no longer hovering over the trigger).

Steps to reproduce the bug

Can be demonstrated in the Tooltips doc page: https://reakit.io/docs/tooltip/

Expected behavior

When moving your cursor from the trigger to the pop op, it should remain visible (and probably allow you to select the text inside).

Possible solutions

Sorry, I'm not familiar with the code base.

Environment

N/A

@open-collective-bot
Copy link

Hey @samsch 馃憢,

Thank you for opening an issue. We'll get back to you as soon as we can.
Please, consider supporting us on Open Collective. We give a special attention to issues opened by backers.

If you use Reakit at work, you can also ask your company to sponsor us 鉂わ笍.

@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 3, 2022
@samsch
Copy link
Author

samsch commented Jan 3, 2022

Bumping, as this is still a valid issue.

@stale stale bot removed the stale label Jan 3, 2022
@ivanov-v
Copy link

ivanov-v commented Mar 21, 2022

Hello. I also have a need to hover the tooltip, because it has interactive content. For example link or button.

image

image

@diegohaz
Copy link
Member

@ivanov-v Tooltips shouldn't contain interactive content. You're talking about another concept which is usually called "hovercard". There will be a Hovercard component in v2: https://ariakit.org/examples/hovercard

@ivanov-v
Copy link

@ivanov-v Tooltips shouldn't contain interactive content. You're talking about another concept which is usually called "hovercard". There will be a Hovercard component in v2: https://ariakit.org/examples/hovercard

Cool! Can you tell me when it will be safe to use it in production?

@diegohaz
Copy link
Member

diegohaz commented Jul 6, 2022

@ivanov-v Sorry for the delay. You'll find more information on Should I use Ariakit (v2) or Reakit (v1) now?.

@diegohaz diegohaz added feature and removed bug labels Apr 23, 2023
diegohaz added a commit that referenced this issue May 13, 2023
Closes #887
Closes #1595
Closes #2228

The primary purpose of this PR is to move the `@floating-ui/dom`
dependency from the `usePopoverStore` hook to the `Popover` component so
it can be lazy loaded.

In addition, we moved most of the Floating UI-related props to the
`Popover` component, which was the original idea, but wasn't viable
before without hacks. The only exception is the `placement` prop, to
which we need access on components other than `Popover`.

This introduces breaking changes on `Popover` and derived components.
Those are described in the changesets.

---

Finally, the `Tooltip` component has been updated, so it composes
`Hovercard` now, which also benefited from the `Popover` changes. The
specific `Tooltip` updates are related to the closed issues above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants