Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Combobox with autoSelect + autoComplete="both" props #1219

Merged
merged 6 commits into from
Apr 13, 2022

Conversation

diegohaz
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2022

🦋 Changeset detected

Latest commit: 6ef2330

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
ariakit-utils Minor
ariakit Patch
ariakit-playground Patch
ariakit-test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

ariakit – ./

🔍 Inspect: https://vercel.com/ariakit/ariakit/EeTBzy5GC5RULFrRVBB9jd1pu4jP
✅ Preview: https://ariakit-git-combobox-group-example-ariakit.vercel.app

reakit – ./

🔍 Inspect: https://vercel.com/ariakit/reakit/BVu1djK1LcYY1qAubAWvBSL94JE8
✅ Preview: Ignored

[Deployment for 6ef2330 canceled]

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6ef2330:

Sandbox Source
Ariakit Configuration

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1219 (cef7aab) into main (a51925f) will increase coverage by 0.98%.
The diff coverage is 97.22%.

❗ Current head cef7aab differs from pull request most recent head 6ef2330. Consider uploading reports for the commit 6ef2330 to get more accurate results

@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
+ Coverage   80.73%   81.72%   +0.98%     
==========================================
  Files         229      230       +1     
  Lines        5699     5723      +24     
  Branches     1584     1592       +8     
==========================================
+ Hits         4601     4677      +76     
+ Misses       1094     1042      -52     
  Partials        4        4              
Impacted Files Coverage Δ
packages/ariakit/src/combobox/combobox.ts 94.03% <83.33%> (+24.17%) ⬆️
packages/ariakit-utils/src/hooks.ts 87.70% <100.00%> (+0.52%) ⬆️
...src/combobox/__examples__/combobox-group/index.tsx 100.00% <100.00%> (ø)
...c/combobox/__examples__/combobox-matches/index.tsx 100.00% <100.00%> (ø)
packages/ariakit/src/combobox/combobox-state.ts 98.11% <100.00%> (-0.04%) ⬇️
...t/src/dialog/__utils/use-focus-on-child-unmount.ts 100.00% <0.00%> (+7.14%) ⬆️
packages/ariakit/src/combobox/combobox-group.ts 100.00% <0.00%> (+66.66%) ⬆️
...ackages/ariakit/src/combobox/combobox-separator.ts 100.00% <0.00%> (+75.00%) ⬆️
...kages/ariakit/src/combobox/combobox-group-label.ts 100.00% <0.00%> (+75.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a51925f...6ef2330. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview – reakit April 13, 2022 10:10 Inactive
@diegohaz diegohaz merged commit 9de3e45 into main Apr 13, 2022
@diegohaz diegohaz deleted the combobox-group-example branch April 13, 2022 10:12
@github-actions github-actions bot mentioned this pull request Apr 13, 2022
@diegohaz diegohaz mentioned this pull request Apr 13, 2022
69 tasks
natanelia pushed a commit to natanelia/ariakit that referenced this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant