Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hovercard not cleaning up its hide timeout #2289

Merged
merged 2 commits into from Apr 21, 2023

Conversation

diegohaz
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2023

🦋 Changeset detected

Latest commit: 675f011

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@ariakit/react-core Patch
@ariakit/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ariakit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 4:25pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
reakit ⬜️ Ignored (Inspect) Apr 21, 2023 4:25pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 675f011:

Sandbox Source
Ariakit Configuration

@diegohaz diegohaz merged commit 33cae3d into main Apr 21, 2023
15 checks passed
@diegohaz diegohaz deleted the hovercard-timeout-cleanup-on-unmount branch April 21, 2023 16:34
@github-actions github-actions bot mentioned this pull request Apr 21, 2023
diegohaz pushed a commit that referenced this pull request Apr 21, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @ariakit/core@0.1.2

### Patch Changes

-   Added `isFalsyBooleanCallback` method.

## @ariakit/react@0.1.3

### Patch Changes

- Fixed `Dialog` not returning focus when closed when rendered with
`React.lazy`. ([#2290](#2290))

- Fixed `Hovercard` being shown on touch/tap on mobile devices.
([#2291](#2291))

- Fixed `Hovercard` not properly cleaning up the timeout to hide the
card when
    unmounted. ([#2289](#2289))

- Updated dependencies: `@ariakit/react-core@0.1.3`,
`@ariakit/core@0.1.2`.

## @ariakit/react-core@0.1.3

### Patch Changes

- Fixed `Dialog` not returning focus when closed when rendered with
`React.lazy`. ([#2290](#2290))

- Fixed `Hovercard` being shown on touch/tap on mobile devices.
([#2291](#2291))

- Fixed `Hovercard` not properly cleaning up the timeout to hide the
card when
    unmounted. ([#2289](#2289))

-   Updated dependencies: `@ariakit/core@0.1.2`.

## @ariakit/test@0.1.2

### Patch Changes

-   Updated dependencies: `@ariakit/core@0.1.2`.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant