Improve support for nested dialogs #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
🦋 Changeset detectedLatest commit: e2a4ecf The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e2a4ecf:
|
Merged
diegohaz
pushed a commit
that referenced
this pull request
Apr 24, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @ariakit/react@0.1.4 ### Patch Changes - Added support for the `inert` attribute on the `Dialog` component. If the browser supports `inert`, modal dialogs will now use it rather than focus trap regions. ([#2301](#2301)) - Fixed nested modal `Dialog` also closing the parent dialog when clicking outside. ([#2300](#2300)) - Fixed modal `Dialog` eventually losing focus to `document.body`. ([#2300](#2300)) - Fixed `Combobox` with `autoSelect` and `autoComplete` set to `both` or `inline` where the completion string would lose its selected state. ([#2308](#2308)) - Fixed `Combobox` not processing composition text (like chinese characters or accents). ([#2308](#2308)) - Updated dependencies: `@ariakit/react-core@0.1.4`. ## @ariakit/react-core@0.1.4 ### Patch Changes - Added support for the `inert` attribute on the `Dialog` component. If the browser supports `inert`, modal dialogs will now use it rather than focus trap regions. ([#2301](#2301)) - Fixed nested modal `Dialog` also closing the parent dialog when clicking outside. ([#2300](#2300)) - Fixed modal `Dialog` eventually losing focus to `document.body`. ([#2300](#2300)) - Fixed `Combobox` with `autoSelect` and `autoComplete` set to `both` or `inline` where the completion string would lose its selected state. ([#2308](#2308)) - Fixed `Combobox` not processing composition text (like chinese characters or accents). ([#2308](#2308)) ## @ariakit/test@0.1.3 ### Patch Changes - Added support for elements becoming inaccessible between `mousedown` and `mouseup` events on the `click` function. ([#2300](#2300)) - Added support for composition text on `type`. ([#2308](#2308)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2298
This PR adds an example for nested dialogs and fixes two related bugs:
document.bodyelement. Now we're constantly checkingdocument.activeElementto see if the focus was lost, in which case we move the focus to the dialog element itself.