Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll jump on dynamically rendered Select #2322

Merged
merged 2 commits into from Apr 26, 2023

Conversation

diegohaz
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ariakit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 9:36pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
reakit ⬜️ Ignored (Inspect) Apr 26, 2023 9:36pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

🦋 Changeset detected

Latest commit: 1c219da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@ariakit/react-core Patch
@ariakit/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 26, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c219da:

Sandbox Source
Ariakit Configuration

@diegohaz diegohaz merged commit 9033d18 into main Apr 26, 2023
15 checks passed
@diegohaz diegohaz deleted the select-mounted-scroll-jump branch April 26, 2023 21:44
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
diegohaz pushed a commit that referenced this pull request Apr 27, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @ariakit/core@0.1.4

### Patch Changes

-   Updated JSDocs.

## @ariakit/react@0.1.6

### Patch Changes

- Fixed `Select` component causing a scroll jump when it's dynamically
rendered in a portal.
([#2322](#2322))

- Fixed a bug where passing controlled props to a component store
wouldn't always call the state setter with an updated value.
([#2328](#2328))

- Fixed `Menu` not respecting `hidden={false}`.
([#2328](#2328))

-   Updated JSDocs.

- Updated dependencies: `@ariakit/react-core@0.1.6`,
`@ariakit/core@0.1.4`.

## @ariakit/react-core@0.1.6

### Patch Changes

- Added `FocusableContainer` component to control whether `Focusable`
components inside it can be auto focused when they have the `autoFocus`
prop. ([#2322](#2322))

- Fixed `Select` component causing a scroll jump when it's dynamically
rendered in a portal.
([#2322](#2322))

- Fixed a bug where passing controlled props to a component store
wouldn't always call the state setter with an updated value.
([#2328](#2328))

- Fixed `Menu` not respecting `hidden={false}`.
([#2328](#2328))

-   Updated JSDocs.

-   Updated dependencies: `@ariakit/core@0.1.4`.

## @ariakit/test@0.1.5

### Patch Changes

-   Updated dependencies: `@ariakit/core@0.1.4`.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant