Fix composite typeahead when the item text starts with a space #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a4647be The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a4647be:
|
Merged
diegohaz
pushed a commit
that referenced
this pull request
May 30, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @ariakit/react@0.2.4 ### Patch Changes - The `Checkbox` component now accepts `string[]` as the `value` prop. This is to conform with the native input prop type. If a string array is passed, it will be stringified, just like in the native input element. ([#2456](#2456)) - Fixed the `clickOnEnter` prop on `Checkbox` not working when rendering the component as a native input element. ([#2456](#2456)) - Fixed typeahead behavior when the composite item element's text content starts with an empty space. ([#2475](#2475)) - Removed the delay before focusing on the final focus element when a dialog is closed. ([#2462](#2462)) - Fixed `Dialog` wrongly focusing on the final focus element when a dialog is closed by clicking on another dialog. ([#2462](#2462)) - Fixed `Disclosure` timing to set the `disclosureElement` state on the disclosure store. ([#2462](#2462)) - Removed the `hideOnControl` prop from `Hovercard`. ([#2478](#2478)) - Fixed clicking outside a `Dialog` when there's an ancestor element between the dialog content element and the portal element. ([#2482](#2482)) - Fixed `Popover` with the `updatePosition` prop not moving focus into the popover when it opens. ([#2482](#2482)) - Updated the `updatePosition` prop type on `Popover` to allow for returning a `Promise`. ([#2482](#2482)) - Updated dependencies: `@ariakit/react-core@0.2.4`. ## @ariakit/react-core@0.2.4 ### Patch Changes - The `Checkbox` component now accepts `string[]` as the `value` prop. This is to conform with the native input prop type. If a string array is passed, it will be stringified, just like in the native input element. ([#2456](#2456)) - Fixed the `clickOnEnter` prop on `Checkbox` not working when rendering the component as a native input element. ([#2456](#2456)) - Fixed typeahead behavior when the composite item element's text content starts with an empty space. ([#2475](#2475)) - Removed the delay before focusing on the final focus element when a dialog is closed. ([#2462](#2462)) - Fixed `Dialog` wrongly focusing on the final focus element when a dialog is closed by clicking on another dialog. ([#2462](#2462)) - Fixed `Disclosure` timing to set the `disclosureElement` state on the disclosure store. ([#2462](#2462)) - Removed the `hideOnControl` prop from `Hovercard`. ([#2478](#2478)) - Fixed clicking outside a `Dialog` when there's an ancestor element between the dialog content element and the portal element. ([#2482](#2482)) - Fixed `Popover` with the `updatePosition` prop not moving focus into the popover when it opens. ([#2482](#2482)) - Updated the `updatePosition` prop type on `Popover` to allow for returning a `Promise`. ([#2482](#2482)) ## @ariakit/test@0.1.10 ### Patch Changes - Fixed several actions not considering hidden elements before dispatching events, which was causing a freeze in JSDOM. ([#2462](#2462)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trim the composite item element's text before comparing it with the pressed key.