Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deeply nested dialogs not restoring elements outside #2507

Merged
merged 5 commits into from Jun 2, 2023

Conversation

diegohaz
Copy link
Member

@diegohaz diegohaz commented Jun 2, 2023

Closes #2501

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2023

🦋 Changeset detected

Latest commit: b48e62f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@ariakit/react-core Patch
@ariakit/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ariakit ✅ Ready (Inspect) Visit Preview Jun 2, 2023 1:09pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
reakit ⬜️ Ignored (Inspect) Jun 2, 2023 1:09pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b48e62f:

Sandbox Source
Ariakit Configuration

@diegohaz diegohaz merged commit c206013 into main Jun 2, 2023
14 checks passed
@diegohaz diegohaz deleted the dialog-nested-multiple branch June 2, 2023 13:12
@github-actions github-actions bot mentioned this pull request Jun 2, 2023
diegohaz pushed a commit that referenced this pull request Jun 2, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @ariakit/react@0.2.7

### Patch Changes

- Fixed deeply nested `Dialog` not removing the `inert` attribute from
elements outside when closed.
([#2507](#2507))

-   Updated dependencies: `@ariakit/react-core@0.2.7`.

## @ariakit/react-core@0.2.7

### Patch Changes

- Fixed deeply nested `Dialog` not removing the `inert` attribute from
elements outside when closed.
([#2507](#2507))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inert attribute is not removed after nested dialog is closed
1 participant