Make composite items tabbable before hydration #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6b71d29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6b71d29:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Merged
diegohaz
pushed a commit
that referenced
this pull request
Jun 29, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @ariakit/react@0.2.12 ### Patch Changes - Fixed `CompositeItem` not being tabbable before hydration. ([#2601](#2601)) - Updated dependencies: `@ariakit/react-core@0.2.12`. ## @ariakit/react-core@0.2.12 ### Patch Changes - Fixed `CompositeItem` not being tabbable before hydration. ([#2601](#2601)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
diegohaz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic that controls whether a composite item is tabbable before hydration. The previous logic was trying to read
store.item(id), which could be populated on the initial render if the developer is passing anitemsordefaultItemsprop to the composite store. Instead, we'll readstate.renderedItems.length, which will only be truthy after the items are rendered and registered to the store.