Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft deprecate the as prop #2621

Merged
merged 2 commits into from Jul 4, 2023
Merged

Soft deprecate the as prop #2621

merged 2 commits into from Jul 4, 2023

Conversation

diegohaz
Copy link
Member

@diegohaz diegohaz commented Jul 4, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2023

🦋 Changeset detected

Latest commit: 2f9217f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@ariakit/react-core Patch
@ariakit/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ariakit 🛑 Canceled (Inspect) Jul 4, 2023 8:41am
1 Ignored Deployment
Name Status Preview Updated (UTC)
reakit ⬜️ Ignored (Inspect) Jul 4, 2023 8:41am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2f9217f:

Sandbox Source
Ariakit Configuration

@diegohaz diegohaz merged commit 77804cf into main Jul 4, 2023
14 checks passed
@diegohaz diegohaz deleted the as-prop-soft-deprecate branch July 4, 2023 08:43
This was referenced Jul 4, 2023
diegohaz pushed a commit that referenced this pull request Jul 26, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @ariakit/react@0.2.13

### Patch Changes

- The `as` prop has been soft deprecated. Use the
[`render`](https://ariakit.org/guide/composition) prop instead.
([#2621](#2621))

- The `Combobox` component now properly disables the `autoSelect`
behavior when the user is scrolling through the list of options. This
should prevent issues when scrolling virtualized or infinite lists.
([#2617](#2617))

- Fixed `Combobox` with `autoSelect` always focusing on the first item
when a virtualized list is scrolled using arrow keys.
([#2636](#2636))

- Controlled store updates are now flushed synchronously. This should
prevent issues when controlling a `Combobox` by passing `value` and
`setValue` to the combobox store, for example.
([#2671](#2671))

-   Updated dependencies: `@ariakit/react-core@0.2.13`.

## @ariakit/react-core@0.2.13

### Patch Changes

- The `as` prop has been soft deprecated. Use the
[`render`](https://ariakit.org/guide/composition) prop instead.
([#2621](#2621))

- The `Combobox` component now properly disables the `autoSelect`
behavior when the user is scrolling through the list of options. This
should prevent issues when scrolling virtualized or infinite lists.
([#2617](#2617))

- Fixed `Combobox` with `autoSelect` always focusing on the first item
when a virtualized list is scrolled using arrow keys.
([#2636](#2636))

- Added experimental element keys to the `Role` component.
([#2660](#2660))

- The `SelectRenderer` component doesn't require a store prop or context
anymore. ([#2619](#2619))

- Controlled store updates are now flushed synchronously. This should
prevent issues when controlling a `Combobox` by passing `value` and
`setValue` to the combobox store, for example.
([#2671](#2671))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant