New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Menu
scroll jump
#801
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f7b47f8:
|
Size Change: +258 B (0%) Total Size: 257 kB
ℹ️ View Unchanged
|
✔️ Deploy preview for reakit ready! 🔨 Explore the source changes: f7b47f8 🔍 Inspect the deploy logs: https://app.netlify.com/sites/reakit/deploys/5fcae621588c180008ab063d 😎 Browse the preview: https://deploy-preview-801--reakit.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #801 +/- ##
==========================================
- Coverage 95.44% 95.36% -0.09%
==========================================
Files 229 230 +1
Lines 3494 3497 +3
Branches 950 953 +3
==========================================
Hits 3335 3335
- Misses 158 161 +3
Partials 1 1
Continue to review full report at Codecov.
|
Closes #751
Updated the popover state to update the popper styles in the main phase so they're defined before the menu popover receives focus. I'm still not sure if this is the right solution nor the side effects it could have. I need to read Popper.js docs more carefully.
How to test?
Follow the reproduction steps on #751 on https://deploy-preview-801--reakit.netlify.app/
Does this PR introduce breaking changes?
No