-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add form
example
#966
Conversation
This pull request is being automatically deployed with Vercel (learn more). ariakit – ./🔍 Inspect: https://vercel.com/ariakit/ariakit/3vNbWfsY5g8PfhLtvgGS2FSpvEtc reakit – ./🔍 Inspect: https://vercel.com/ariakit/reakit/9Jm2miZFZbqH27ftaC9BrMrA9hWP |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report
@@ Coverage Diff @@
## v2 #966 +/- ##
==========================================
+ Coverage 54.20% 62.48% +8.28%
==========================================
Files 157 158 +1
Lines 4118 4124 +6
Branches 1159 1159
==========================================
+ Hits 2232 2577 +345
+ Misses 1885 1546 -339
Partials 1 1
Continue to review full report at Codecov.
|
@@ -50,6 +51,7 @@ export const useFormInput = createHook<FormInputOptions>( | |||
onChange, | |||
}; | |||
|
|||
props = useFocusable(props); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to add this because FormInput
was missing the focus-visible features.
@@ -269,6 +269,7 @@ module.exports = { | |||
}); | |||
|
|||
addVariant("ariakit-focus-visible", "&[data-focus-visible]"); | |||
addVariant("aria-invalid", '&[aria-invalid="true"]'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ended up not needing this selector here, but might be useful in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.