Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add form example #966

Merged
merged 1 commit into from
Dec 25, 2021
Merged

chore: Add form example #966

merged 1 commit into from
Dec 25, 2021

Conversation

diegohaz
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Dec 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

ariakit – ./

🔍 Inspect: https://vercel.com/ariakit/ariakit/3vNbWfsY5g8PfhLtvgGS2FSpvEtc
✅ Preview: https://ariakit-git-chore-form-example-ariakit.vercel.app

reakit – ./

🔍 Inspect: https://vercel.com/ariakit/reakit/9Jm2miZFZbqH27ftaC9BrMrA9hWP
✅ Preview: Canceled

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

codecov bot commented Dec 25, 2021

Codecov Report

Merging #966 (82a6c14) into v2 (ad77c40) will increase coverage by 8.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2     #966      +/-   ##
==========================================
+ Coverage   54.20%   62.48%   +8.28%     
==========================================
  Files         157      158       +1     
  Lines        4118     4124       +6     
  Branches     1159     1159              
==========================================
+ Hits         2232     2577     +345     
+ Misses       1885     1546     -339     
  Partials        1        1              
Impacted Files Coverage Δ
...kages/ariakit/src/form/__examples__/form/index.tsx 100.00% <100.00%> (ø)
packages/ariakit/src/form/form-input.ts 100.00% <100.00%> (+100.00%) ⬆️
packages/ariakit/src/form/form-push.ts 4.54% <0.00%> (+4.54%) ⬆️
packages/ariakit/src/form/form-remove.ts 5.12% <0.00%> (+5.12%) ⬆️
packages/ariakit/src/form/form-radio.ts 10.52% <0.00%> (+10.52%) ⬆️
packages/ariakit/src/form/form-description.ts 10.52% <0.00%> (+10.52%) ⬆️
packages/ariakit/src/form/form-checkbox.ts 13.33% <0.00%> (+13.33%) ⬆️
packages/ariakit/src/form/form-radio-group.ts 22.22% <0.00%> (+22.22%) ⬆️
packages/ariakit/src/form/form-group-label.ts 25.00% <0.00%> (+25.00%) ⬆️
packages/ariakit/src/form/form-group.ts 28.57% <0.00%> (+28.57%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad77c40...82a6c14. Read the comment docs.

@diegohaz diegohaz mentioned this pull request Dec 25, 2021
69 tasks
@@ -50,6 +51,7 @@ export const useFormInput = createHook<FormInputOptions>(
onChange,
};

props = useFocusable(props);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add this because FormInput was missing the focus-visible features.

@@ -269,6 +269,7 @@ module.exports = {
});

addVariant("ariakit-focus-visible", "&[data-focus-visible]");
addVariant("aria-invalid", '&[aria-invalid="true"]');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up not needing this selector here, but might be useful in the future.

Copy link
Member

@saideepesh000 saideepesh000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@diegohaz diegohaz merged commit 6304ccd into v2 Dec 25, 2021
@diegohaz diegohaz deleted the chore/form-example branch December 25, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants