Skip to content

Commit

Permalink
fix #1321 avoid downloading default request handler and url service
Browse files Browse the repository at this point in the history
This commit avoids downloading default request handler and url
services until they are really needed (especially, if a request
handler or url service is specified at the request level, it is
not needed to download the default ones).
  • Loading branch information
divdavem committed Oct 23, 2014
1 parent 1cf4a0e commit 0815eb7
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/aria/modules/RequestMgr.js
Original file line number Diff line number Diff line change
Expand Up @@ -274,16 +274,17 @@ module.exports = Aria.classDefinition({

/**
* Return an array of dependencies from used handlers : urlService, requestHandler
* @param {aria.modules.RequestBeans:RequestObject} requestObject
* @private
* @return Array
*/
__getHandlersDependencies : function () {
__getHandlersDependencies : function (requestObject) {
var dependencies = [], appEnv = ariaModulesUrlServiceEnvironmentUrlService;
if (!this._urlService) {
if (!requestObject.urlService && !this._urlService) {
var urlServiceCfg = appEnv.getUrlServiceCfg();
dependencies.push(urlServiceCfg.implementation);
}
if (!this._requestHandler) {
if (!requestObject.requestHandler && !this._requestHandler) {
var requestHandlerCfg = ariaModulesRequestHandlerEnvironmentRequestHandler.getRequestHandlerCfg();
dependencies.push(requestHandlerCfg.implementation);
}
Expand Down Expand Up @@ -312,7 +313,7 @@ module.exports = Aria.classDefinition({
method : "POST"
}, id = this._idCounter++;

var dependencies = this.__getHandlersDependencies();
var dependencies = this.__getHandlersDependencies(requestObject);

var args = {
req : req,
Expand Down

0 comments on commit 0815eb7

Please sign in to comment.