Skip to content

Commit

Permalink
fix #1312 increase timeout for slow tests (IE7/8)
Browse files Browse the repository at this point in the history
timeout increased from 40s to 120ms for the following failing tests:
   *  test.aria.widgets.form.multiautocomplete.test11.MultiAutoInvalidDataModel
   *  test.aria.widgets.form.multiautocomplete.preselectAutofill.StrictTrueTest
   *  test.aria.widgets.form.multiautocomplete.preselectAutofill.AlwaysFalseTest
   *  test.aria.widgets.form.multiautocomplete.preselectAutofill.NoneTrueTest
   *  test.aria.widgets.form.multiautocomplete.preselectAutofill.NoneFalseTest
   *  test.aria.widgets.form.multiautocomplete.preselectAutofill.StrictTrueWithTabTest
   *  test.aria.widgets.form.multiautocomplete.preselectAutofill.AlwaysTrueTest

and specifically on IE7:
   *  test.aria.widgets.form.autocomplete.preselectAutofill.AlwaysTrueTest
   *  test.aria.widgets.form.datepicker.errorstate.DatePicker
   *  test.aria.widgets.form.textinput.onblur.OnBlurTest
   *  test.aria.widgets.form.selectbox.checkValue.MainTemplateTestCase
   *  test.aria.widgets.form.textinput.onclick.OnClickTest


close #1312
  • Loading branch information
lsimone committed Oct 3, 2014
1 parent d7d825c commit bdd6383
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 6 deletions.
Expand Up @@ -49,8 +49,8 @@ Aria.classDefinition({
"aria.utils.Type", "aria.core.Browser"],
$constructor : function () {
this.$RobotTestCase.constructor.call(this);
if (aria.core.Browser.isPhantomJS || aria.core.Browser.isIE7) {
this.defaultTestTimeout = 40000;
if (aria.core.Browser.isPhantomJS || aria.core.Browser.isIE7 || aria.core.Browser.isIE8) {
this.defaultTestTimeout = 120000;
}
this.resourcesHandler = this.resourcesHandler || new aria.resources.handlers.LCResourcesHandler();
this.resourcesHandler.setSuggestions([{
Expand Down
4 changes: 2 additions & 2 deletions test/aria/widgets/form/datepicker/errorstate/DatePicker.js
Expand Up @@ -21,8 +21,8 @@ Aria.classDefinition({
this.$RobotTestCase.constructor.call(this);
// TODO this test is ridiculously long, split it
this.defaultTestTimeout = 40000;
if (aria.core.Browser.isIE7) {
this.defaultTestTimeout = 50000;
if (aria.core.Browser.isIE7 || aria.core.Browser.isIE8) {
this.defaultTestTimeout = 120000;
} else if (aria.core.Browser.isPhantomJS) {
this.defaultTestTimeout = 60000;
}
Expand Down
Expand Up @@ -19,8 +19,8 @@ Aria.classDefinition({
$dependencies : ["aria.core.Browser"],
$constructor : function () {
this.$BaseMultiAutoCompleteTestCase.constructor.call(this);
if (aria.core.Browser.isPhantomJS) {
this.defaultTestTimeout = 40000;
if (aria.core.Browser.isPhantomJS || aria.core.Browser.isIE7 || aria.core.Browser.isIE8) {
this.defaultTestTimeout = 120000;
}
this.data.freeText = false;
},
Expand Down
Expand Up @@ -53,6 +53,9 @@ Aria.classDefinition({
data : this.data
});
this.defaultTestTimeout = 10000;
if (aria.core.Browser.isIE7 || aria.core.Browser.isIE8) {
this.defaultTestTimeout = 60000;
}
},
$prototype : {
/**
Expand Down
4 changes: 4 additions & 0 deletions test/aria/widgets/form/textinput/onblur/OnBlurTest.js
Expand Up @@ -18,6 +18,10 @@ Aria.classDefinition({
$extends : "test.aria.widgets.form.textinput.onclick.OnClickTest",
$constructor : function () {
this.$OnClickTest.constructor.call(this);
this.defaultTestTimeout = 40000;
if (aria.core.Browser.isIE7 || aria.core.Browser.isIE8) {
this.defaultTestTimeout = 120000;
}
this.setTestEnv({
template : "test.aria.widgets.form.textinput.onblur.OnBlurTemplate",
data : {
Expand Down
3 changes: 3 additions & 0 deletions test/aria/widgets/form/textinput/onclick/OnClickTest.js
Expand Up @@ -25,6 +25,9 @@ Aria.classDefinition({
}
});
this.defaultTestTimeout = 10000;
if (aria.core.Browser.isIE7 || aria.core.Browser.isIE8) {
this.defaultTestTimeout = 60000;
}
this._delay = 200;
this._widgetIds = ["df", "tf", "nf", "pf", "dp", "ac", "ms", "time", "sb", "mac"];
this._currentIndex = null;
Expand Down

0 comments on commit bdd6383

Please sign in to comment.