Skip to content

Commit

Permalink
fix #434 iframe tests timing out in devmode
Browse files Browse the repository at this point in the history
Iframe loader kept waiting indefinitely for the skin to be loaded
in dev mode. This was a clear code mistake, since the skin is loaded
actually later in loadSkin() function.

The problem was manifesting itself in browser-based test runner.
An example failing test: test.aria.widgets.container.dialog.MaximizableDialogTest
  • Loading branch information
jakub-g authored and divdavem committed Mar 22, 2013
1 parent f489ae6 commit be08a8e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions test/iframeLoaderOs.js
Expand Up @@ -33,8 +33,7 @@
window.loader = { window.loader = {
changeRootFolder : function () { changeRootFolder : function () {
// Need to wait for some special classes to be here, before to continue // Need to wait for some special classes to be here, before to continue
if (window.Aria && window.aria && window.aria.core && window.aria.core.DownloadMgr && aria.core.MultiLoader if (window.Aria && window.aria && window.aria.core && window.aria.core.DownloadMgr && aria.core.MultiLoader) {
&& (!isDev || (aria.widgets && aria.widgets.AriaSkin))) {
Aria.rootFolderPath = baseUrl + "/"; Aria.rootFolderPath = baseUrl + "/";
aria.core.DownloadMgr.updateRootMap({ aria.core.DownloadMgr.updateRootMap({
"aria" : { "aria" : {
Expand Down

0 comments on commit be08a8e

Please sign in to comment.