fix #1297 Resizable dialog is not working inside a page with some scroll

This fix is changing the way we set the position of the resizable overlay, using the real position of the element insted of its position inside the viewport.
ariatemplates · Sep 24, 2014 · d3c1ae5 · d3c1ae5
1 parent 32b3740
commit d3c1ae5
Show file tree

Hide file tree

Showing 8 changed files with 580 additions and 446 deletions.
diff --git a/src/aria/utils/overlay/Overlay.js b/src/aria/utils/overlay/Overlay.js
@@ -102,8 +102,9 @@ module.exports = Aria.classDefinition({
             var geometry = ariaUtilsDom.getGeometry(element);
             if (geometry) {
                 overlayStyle.position = "absolute";
-                overlayStyle.top = geometry.y + "px";
-                overlayStyle.left = geometry.x + "px";
+                var scroll = dom.getDocumentScrollElement();
+                overlayStyle.top = geometry.y + scroll.scrollTop + "px";
+                overlayStyle.left = geometry.x + scroll.scrollLeft + "px";
                 overlayStyle.width = (geometry.width - border.left - border.right) + "px";
                 overlayStyle.height = (geometry.height - border.top - border.bottom) + "px";
                 overlayStyle.display = "block";

diff --git a/test/aria/widgets/container/dialog/resize/AbstractResizableDialogTestCase.js b/test/aria/widgets/container/dialog/resize/AbstractResizableDialogTestCase.js
diff --git a/test/aria/widgets/container/dialog/resize/DialogResizeTestSuite.js b/test/aria/widgets/container/dialog/resize/DialogResizeTestSuite.js
@@ -21,6 +21,8 @@ Aria.classDefinition({
 
         this._tests = ["test.aria.widgets.container.dialog.resize.test1.DialogOnResizeTestCase",
                 "test.aria.widgets.container.dialog.resize.test2.ResizableDialogTestCase",
-                "test.aria.widgets.container.dialog.resize.test3.DialogOnResizeTestCase"];
+                "test.aria.widgets.container.dialog.resize.test3.DialogOnResizeTestCase",
+                "test.aria.widgets.container.dialog.resize.test4.DialogOnResizeScrollTestCase",
+                "test.aria.widgets.container.dialog.resize.test5.OverlayOnResizeScrollTestCase"];
     }
 });