Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height and width styles are not taken into account in attributes of html templates #142

Closed
captainbrosset opened this issue Sep 19, 2012 · 5 comments

Comments

@captainbrosset
Copy link
Contributor

When defining the style attributes in a html:template, seems like the height and width properties are either parsed out or removed afterwards.

Consider this code:

    {@html:Template { 
      "classpath" : "app.rm.templates.pages.Workspace",
      "attributes" : {
        "classList" : ["fill-height"],
        style: "border:1px solid red;height:10px;padding:10px;width:500px;"
      }
    }/}

Once the dom is generated, here is the result:

<div style="border: 1px solid red; padding: 10px;" class="fill-height CSS4" id="w1" _template="app.rm.templates.pages.Workspace" atdelegate="d10">...</div>

Thanks for your help

@ghost ghost assigned benouat Oct 15, 2012
@benouat
Copy link
Member

benouat commented Oct 17, 2012

Problem is coming from the layout manager that does not check that a width or/and an height are already there on the wrapper div.

It just try to recompute some sizes, even if you don't use some, and erase any existing value

@jakub-g
Copy link
Collaborator

jakub-g commented Oct 19, 2012

Reverted by the commit d542653 due to introducing a regression on a demo page (unable to scroll, cross-browser).

@jakub-g jakub-g reopened this Oct 19, 2012
@ghost ghost assigned Gprasad Dec 4, 2012
susant123 pushed a commit to susant123/ariatemplates that referenced this issue Dec 10, 2012
Gprasad added a commit to Gprasad/ariatemplates that referenced this issue Dec 10, 2012
@flongo flongo closed this as completed in dd0c8b7 Dec 10, 2012
@flongo
Copy link
Collaborator

flongo commented Dec 10, 2012

Commit dd0c8b7 is linked to this issue.

@divdavem
Copy link
Member

@susant123 Wouldn't it be a good idea to add a unit test so that there is no regression in the future?

Please also have a look to my comment here, and maybe find a fix for that case as well.

@divdavem divdavem reopened this Dec 10, 2012
susant123 pushed a commit to susant123/ariatemplates that referenced this issue Dec 11, 2012
fix ariatemplates#142 height and width style attribute in html templates (Resetting height and width to blank once loading indicator is removed)

fix ariatemplates#142 height and style attribute in html templates(Resetting height and width to blank once loading indicator is removed)
susant123 pushed a commit to susant123/ariatemplates that referenced this issue Dec 14, 2012
@divdavem
Copy link
Member

See my remark in 695fbfa

@divdavem divdavem reopened this Dec 18, 2012
divdavem added a commit to divdavem/ariatemplates that referenced this issue Dec 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants