feat #1677 WAI-ARIA - DatePicker - Reading the input date when valid #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (onCall == null) { | ||
| onCall = nop; | ||
| } | ||
| this.onCall = onCall; |
There was a problem hiding this comment.
onCall is not used anywhere. Please remove it.
ymeine
force-pushed
the
feat/widgets/wai/date-picker
branch
from
1b7e9cd
to
4540a17
Compare
ymeine
added a commit
to ymeine/ariatemplates
that referenced
this pull request
Sep 8, 2016
…e when valid Now when the user inputs a date, be it from the calendar or when typing in, if the date is valid it is read by the screen reader following a provided format: waiAriaConfirmDateFormat (which defaults to waiAriaDateFormat or a long date format). When the user types the text in, a debouncing algorithm is applied, which is controlled by a delay waiAriaConfirmDateDelay, defaulting to 50 ms. References: - AT-1509 close ariatemplates#1677
…nk widget Also made the following change to all "ActionWidget" based widgets: now the "aria-disabled" attribute is not set anymore in WAI-ARIA mode, "disabled" must be sufficient. References: - AT-1398 - PTR 11630074 close ariatemplates#1675
ymeine
force-pushed
the
feat/widgets/wai/date-picker
branch
from
4540a17
to
4056491
Compare
ymeine
added a commit
to ymeine/ariatemplates
that referenced
this pull request
Sep 8, 2016
…e when valid Now when the user inputs a date, be it from the calendar or when typing in, if the date is valid it is read by the screen reader following a provided format: waiAriaConfirmDateFormat (which defaults to waiAriaDateFormat or a long date format). When the user types the text in, a debouncing algorithm is applied, which is controlled by a delay waiAriaConfirmDateDelay, defaulting to 50 ms. References: - AT-1509 close ariatemplates#1677
…e when valid Now when the user inputs a date, be it from the calendar or when typing in, if the date is valid it is read by the screen reader following a provided format: waiAriaConfirmDateFormat (which defaults to waiAriaDateFormat or a long date format). When the user types the text in, a debouncing algorithm is applied, which is controlled by a delay waiAriaConfirmDateDelay, defaulting to 50 ms. References: - AT-1509 close ariatemplates#1677
ymeine
force-pushed
the
feat/widgets/wai/date-picker
branch
from
4056491
to
fe5721d
Compare
divdavem
pushed a commit
that referenced
this pull request
Sep 16, 2016
Now when the user inputs a date, be it from the calendar or when typing in, if the date is valid it is read by the screen reader following a provided format: waiAriaConfirmDateFormat (which defaults to waiAriaDateFormat or a long date format). When the user types the text in, a debouncing algorithm is applied, which is controlled by a delay waiAriaConfirmDateDelay, defaulting to 50 ms. References: - AT-1509 close #1677 (cherry picked from commit fe5721d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when the user inputs a date, be it from the calendar or when typing in, if the date is valid it is read by the screen reader following a provided format: waiAriaConfirmDateFormat (which defaults to waiAriaDateFormat or a long date format).
When the user types the text in, a debouncing algorithm is applied, which is controlled by a delay waiAriaConfirmDateDelay, defaulting to 50 ms.
References: