Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency due to tplScripts extending aria.templates.Template #394

Closed
jakub-g opened this issue Feb 26, 2013 · 0 comments
Closed
Milestone

Comments

@jakub-g
Copy link
Collaborator

jakub-g commented Feb 26, 2013

Currently tplScripts extend aria.templates.Template (this is a remainder of the code that has been removed a long time ago, in 1.0-30).
This can lead to circular dependencies if a template has a CSS template via $css and that CSS template uses a template script.

jakub-g added a commit to jakub-g/ariatemplates that referenced this issue Feb 27, 2013
If a template had a CSS template with script in its dependencies, then
a circular dependency error might have happened due to that. This commit
removes the the dependency of a tplScript on aria.templates.Template
which could lead to that situation.

Additionally, the $constructor and $destructor functions are removed
at Aria.tplScriptDefinition call time to prevent direct instantiation of
tplScripts (but the user can still specify $constructor and $destructor
in their template script and they will be invoked).

Close ariatemplates#395.
@piuccio piuccio closed this as completed in b3b3c80 Mar 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants