Page engine improvements #518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teRootModule controller Close ariatemplates#510
… simpler Two methods have been added to class aria.pageEngine.pageProviders.BasePageProvider: processSiteConfig and processPageDefinition. They are called, respectively, before sending the site configuration and page definitions back to the page engine. This makes it possible to extend the BasePageProvider class by only implementing those two methods.
…sh-based navigation When "navigation" is set to "hash" in the site configuration, the title of the page (specified in the page definition) is used to change the title of the document. This was previously done only in history-based navigation
Tests for the PageEngine class are no longer template tests.
The navigation manager of the page engine was rejecting empty strings from the cache in which url-to-pageId map was stored. This implied that, when navigating back to a page whose url is an empty string, the page engine was unable to infer the pageId and display the correct page. Close ariatemplates#520
…e site configuration Navigation managers used both for hash and for history-based navigations in the page engine rely on local storage browser capabilities to store the associations between urls and pageId's. The saved data is needed in order to identify the right page after hard page reload or when hitting back after an external navigation. Before this code change, the storage could not be configured. Now it can be deactivated, provided with a specific suffix for local storage key and with an expiration delay for its entries.
flongo
added a commit
that referenced
this pull request
Jun 5, 2013
flongo
added a commit
that referenced
this pull request
Jun 5, 2013
Two methods have been added to class aria.pageEngine.pageProviders.BasePageProvider: processSiteConfig and processPageDefinition. They are called, respectively, before sending the site configuration and page definitions back to the page engine. This makes it possible to extend the BasePageProvider class by only implementing those two methods.
flongo
added a commit
that referenced
this pull request
Jun 5, 2013
…gation When "navigation" is set to "hash" in the site configuration, the title of the page (specified in the page definition) is used to change the title of the document. This was previously done only in history-based navigation
flongo
added a commit
that referenced
this pull request
Jun 5, 2013
Tests for the PageEngine class are no longer template tests.
flongo
added a commit
that referenced
this pull request
Jun 5, 2013
…uration Navigation managers used both for hash and for history-based navigations in the page engine rely on local storage browser capabilities to store the associations between urls and pageId's. The saved data is needed in order to identify the right page after hard page reload or when hitting back after an external navigation. Before this code change, the storage could not be configured. Now it can be deactivated, provided with a specific suffix for local storage key and with an expiration delay for its entries.
flongo
added a commit
that referenced
this pull request
Jun 5, 2013
|
All commits have been pushed to master 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit represents a small improvement on the page engine layer.