fix #1055 option stayed selected in Select after removal from options list #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from options list When `@aria:Select` options were bound to the data model, and the currently selected option was removed from the option list through the binding, it still remained as the data model value of the widget (although no longer available in the UI). Close ariatemplates#1218 Close ariatemplates#1309
jakub-g
force-pushed
the
pr1218again
branch
from
f78d282
to
fd91fb2
Compare
jakub-g
changed the title
|
🆗 fd91fb2 seems fine for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of PR #1218
I've changed the test scenario from the first one to the second one reported in #1055 and added some more asserts (the first one was no longer reproducible since it was fixed in 1.6.5, moreover the second scenario was better showing the issue).
When
@aria:Selectoptions were bound to the data model,and the currently selected option was removed from the option list
through the binding, it still remained as the data model value
of the widget (although no longer available in the UI).
Close #1218
Close #1309