Disabled state in html:RadioButton widget #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🆗 8bf4ab6 seems fine for me |
When two `html:RadioButton`s disabled state is bound to the same non-initialized data model, an error was triggered. This was due to the fact that when the `initWidget` method of the first one was called, a `setValue` was done on the data model, which triggered some listeners to modify the disabled state of the second one, for which the `initWidget` method had not been called yet, so that property `this._domElt` had not been set yet.
flongo
force-pushed
the
disabled-radio-button
branch
from
8bf4ab6
to
85bb344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two
html:RadioButtons disabled state is bound to the same non-initialized data model, an error was triggered.This was due to the fact that when the
initWidgetmethod of the first one was called, asetValuewas done on the data model, which triggered some listeners to modify the disabled state of the second one, for which theinitWidgetmethod had not been called yet, so that propertythis._domElthad not been set yet.