fix Better dialog width management depending on the title length #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 1, 2015
…e title length
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 1, 2015
…e title length
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 1, 2015
…e title length
| var dialogs = this.dialogs = {}; | ||
| for (var i = 0; i < dialogIds.length; i += 1) { | ||
| var id = dialogIds[i]; | ||
| var currentInstance = dialogs[dialogIds[i]] = this.getWidgetInstance(dialogIds[i]); |
There was a problem hiding this comment.
It would be better to use id instead of dialogIds[i], otherwise, what's the point of creating the id variable?
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 2, 2015
…e title length
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 2, 2015
…e title length
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 3, 2015
…e title length
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 3, 2015
…e title length
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 3, 2015
…e title length
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 3, 2015
…e title length
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 3, 2015
…e title length
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 3, 2015
…e title length
…e title length
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 4, 2015
fbasso
added a commit
that referenced
this pull request
Jun 4, 2015
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 5, 2015
test.aria.widgets.container.dialog.sizes.DialogWidthTestCase in IE7
fbasso
added a commit
to fbasso/ariatemplates
that referenced
this pull request
Jun 5, 2015
test.aria.widgets.container.dialog.sizes.DialogWidthTestCase in IE7
fbasso
added a commit
that referenced
this pull request
Jun 5, 2015
divdavem
pushed a commit
to divdavem/ariatemplates
that referenced
this pull request
Oct 20, 2015
…e title length (cherry picked from commit bf28263)
divdavem
pushed a commit
to divdavem/ariatemplates
that referenced
this pull request
Oct 20, 2015
(cherry picked from commit dd76112)
divdavem
pushed a commit
to divdavem/ariatemplates
that referenced
this pull request
Oct 20, 2015
For test.aria.widgets.container.dialog.sizes.DialogWidthTestCase in IE7 (cherry picked from commit 20148bf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.