Fixing regression with templates depending on server resources #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divdavem
force-pushed
the
serverResources
branch
from
260745f
to
7019e74
Compare
divdavem
added a commit
to divdavem/ariatemplates
that referenced
this pull request
Jun 19, 2015
…r resources This commit fixes a regression introduced in Aria Templates v1.7.6 (dc9c3ba) : templates which have a server resources dependency (i.e. whose classpath ends with .Res) failed to be loaded. For example, if the template contained something like this: {Template { $classpath : "x.y.MyTemplate", $res : { myRes : "x.y.myResourceName.Res" } } ... That template could not be loaded, with the following error message: [aria.core.MultiLoader] Load failed ReferenceError: myResourceName is not defined
|
Change is fine for me 👍 assuming that the build is fine :) |
divdavem
force-pushed
the
serverResources
branch
from
7019e74
to
527628b
Compare
divdavem
added a commit
to divdavem/ariatemplates
that referenced
this pull request
Jun 19, 2015
…r resources This commit fixes a regression introduced in Aria Templates v1.7.6 (dc9c3ba) : templates which have a server resources dependency (i.e. whose classpath ends with .Res) failed to be loaded. For example, if the template contained something like this: {Template { $classpath : "x.y.MyTemplate", $res : { myRes : "x.y.myResourceName.Res" } } ... That template could not be loaded, with the following error message: [aria.core.MultiLoader] Load failed ReferenceError: myResourceName is not defined
…r resources This commit fixes a regression introduced in Aria Templates v1.7.6 (dc9c3ba) : templates which have a server resources dependency (i.e. whose classpath ends with .Res) failed to be loaded. For example, if the template contained something like this: {Template { $classpath : "x.y.MyTemplate", $res : { myRes : "x.y.myResourceName.Res" } } ... That template could not be loaded, with the following error message: [aria.core.MultiLoader] Load failed ReferenceError: myResourceName is not defined
divdavem
force-pushed
the
serverResources
branch
from
527628b
to
703e64e
Compare
|
@benouat Thank you for your review. I have fixed the test, rebased the branch and integrated it in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression introduced in Aria Templates v1.7.6 (dc9c3ba) :
templates which have a server resources dependency (i.e. whose classpath ends with
.Res) failed to be loaded.For example, if the template contained something like this:
That template could not be loaded, with the following error message: