fix #1521 CheckBox not appearing when using the ATFlatSkin. #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonarbuckle
force-pushed
the
atflatskin
branch
2 times, most recently
from
d0aa0c8
to
799973c
Compare
|
🆗 799973c seems fine for me |
The skin was using a data uri to embed the image data within the background-image of the css for the skin. This was causing problems with IE11 resulting in the failure to load the sprite for the CheckBox. To be consistent and to ensure the bug isn't reproduced with other svg files, the skin has been changed to use gif files instead. close ariatemplates#1522
simonarbuckle
force-pushed
the
atflatskin
branch
from
799973c
to
3e61814
Compare
simonarbuckle
added a commit
that referenced
this pull request
Oct 13, 2015
The skin was using a data uri to embed the image data within the background-image of the css for the skin. This was causing problems with IE11 resulting in the failure to load the sprite for the CheckBox. To be consistent and to ensure the bug isn't reproduced with other svg files, the skin has been changed to use gif files instead. close #1522 (cherry picked from commit cd730ac)
simonarbuckle
added a commit
that referenced
this pull request
Oct 13, 2015
The skin was using a data uri to embed the image data within the background-image of the css for the skin. This was causing problems with IE11 resulting in the failure to load the sprite for the CheckBox. To be consistent and to ensure the bug isn't reproduced with other svg files, the skin has been changed to use gif files instead. close #1522 (cherry picked from commit cd730ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skin was using a data uri to embed the image data within the background-image of the css for the skin. This was causing problems with IE11 and as a result wasn't loading the sprite for the CheckBox.