Fixing test.aria.widgets.autoselect.programmatic.AutoSelect on IE9 and IE10 #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic.AutoSelect on IE9 and IE10 This commit fixes a regression introduced by commit f9d30b6. On IE9 and IE10, setting the selection on the focus event handler itself does not work, it has to be delayed.
divdavem
force-pushed
the
autoselectFix
branch
from
2587a97
to
cbbfb2d
Compare
|
cbbfb2 is fine for me, as the tests are ok on your fork |
|
@fbasso Thank you for your review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced by commit f9d30b6.
On IE9 and IE10, setting the selection on the focus event handler itself does not work, it has to be delayed.