fix JAWS reading dialog title when closing dropdown widget #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divdavem
force-pushed
the
popupInDialogJAWS
branch
from
8904e59
to
b559305
Compare
divdavem
added a commit
to divdavem/ariatemplates
that referenced
this pull request
Jan 22, 2019
…n widget This commit contains a better fix for the problem described in ariatemplates#1797. When a dropdown widget with waiAria:true is inside a dialog with role=dialog the dropdown DOM element is no longer appended to the <body> but to the element that has role=dialog. Therefore, screen readers correctly understand that the dropdown is not outside the dialog and no longer read the dialog title when changing the focus after closing the dropdown. PTR 14068536
…n widget This commit contains a better fix for the problem described in ariatemplates#1797. When a dropdown widget with waiAria:true is inside a dialog with role=dialog the dropdown DOM element is no longer appended to the <body> but to the element that has role=dialog. Therefore, screen readers correctly understand that the dropdown is not outside the dialog and no longer read the dialog title when changing the focus after closing the dropdown. PTR 14068536
divdavem
force-pushed
the
popupInDialogJAWS
branch
from
b559305
to
4810d99
Compare
Codecov Report
@@ Coverage Diff @@
## master #1808 +/- ##
==========================================
- Coverage 81.02% 80.99% -0.03%
==========================================
Files 599 600 +1
Lines 33650 33662 +12
==========================================
+ Hits 27264 27265 +1
- Misses 6386 6397 +11
Continue to review full report at Codecov.
|
ymeine
approved these changes
Jan 23, 2019
|
@ymeine Thank you for your review! |
divdavem
added a commit
that referenced
this pull request
Jan 31, 2019
This commit contains a better fix for the problem described in #1797. When a dropdown widget with waiAria:true is inside a dialog with role=dialog the dropdown DOM element is no longer appended to the <body> but to the element that has role=dialog. Therefore, screen readers correctly understand that the dropdown is not outside the dialog and no longer read the dialog title when changing the focus after closing the dropdown. PTR 14068536 (cherry picked from commit 40b097e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a better fix for the problem described in #1797.
When a dropdown widget with
waiAria:trueis inside a dialog withrole=dialogthe dropdown DOM element is no longer appended to the<body>but to the element that hasrole=dialog. Therefore, screen readers correctly understand that the dropdown is not outside the dialog and no longer read the dialog title when changing the focus after closing the dropdown.