Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/test Issue353RobotTestCase randomly failing on PhantomJS #1818

Merged
merged 1 commit into from Jun 18, 2019

Conversation

divdavem
Copy link
Member

This PR excludes Issue353RobotTestCase from the set of tests run by PhantomJS which makes it run by Firefox in Travis.

@divdavem divdavem requested a review from ymeine June 18, 2019 09:10
Copy link
Contributor

@ymeine ymeine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to the Puppeteer alternative ;)

@divdavem
Copy link
Member Author

@ymeine Thank you for your review!
Indeed, running tests in PhantomJS 1.9.8 is not really relevant anymore.

@divdavem divdavem merged commit 8531464 into ariatemplates:master Jun 18, 2019
divdavem added a commit that referenced this pull request Mar 25, 2021
@divdavem divdavem added this to the 2.4.0 milestone Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants