aria.widgets can be undefined #462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flongo
added a commit
to flongo/ariatemplates
that referenced
this pull request
Apr 16, 2013
When no class in aria.widgets package is loaded, aria.widgets is undefined. Before checking if aria.widgets.AriaSkin is defined, the existence of aria.widgets has to be checked first.
|
The same thing can happen also in I thought I fixed that kinds of problems in de7e2ce but it turns out some of them were overlooked. |
|
I think it cannot happen in that case because Anyway, I will update the class. |
flongo
added a commit
to flongo/ariatemplates
that referenced
this pull request
Apr 16, 2013
When no class in aria.widgets package is loaded, aria.widgets is undefined. Before checking if aria.widgets.AriaSkin is defined, the existence of aria.widgets has to be checked first.
When no class in aria.widgets package is loaded, aria.widgets is undefined. Before checking if aria.widgets.AriaSkin is defined, the existence of aria.widgets has to be checked first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no class in aria.widgets package is loaded,
aria.widgetsis undefined.Before checking if
aria.widgets.AriaSkinis defined, the existence ofaria.widgetshas to be checked first.