MultiAutoComplete - fix #980 and test refactoring #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flongo
added a commit
to flongo/ariatemplates
that referenced
this pull request
Feb 20, 2014
Using class `test.aria.widgets.form.autocomplete.multiautocomplete.BaseMultiAutoCompleteTestCase`, all MultiAutoComplete testcases have been refactored. Close ariatemplates#982
|
|
||
| __wait : function (evt, args) { | ||
| var cb; | ||
| args.text.splice(0, 1); |
There was a problem hiding this comment.
You could also use: args.text.shift()
Or, as this expression returns the value of the item being removed, you could even use this expression in the type method instead of args.text[0].
|
Thank you. I will apply the suggested changes and integrate |
…ound data is not empty When freeText option was set to false, items already present in the data model to which the value of the widget is bound were not taken into account. This commit reverts a fix done for another bug within commit 41d50bf: when freeText is equal to false, type some text for which there is no suggestion. Then blur. Then click inside the field and type something for which suggestions are returned. Pressing ENTER would cause all items to be duplicated.
Using class `test.aria.widgets.form.autocomplete.multiautocomplete.BaseMultiAutoCompleteTestCase`, all MultiAutoComplete testcases have been refactored. Close ariatemplates#982
carlo-mr
pushed a commit
to carlo-mr/ariatemplates
that referenced
this pull request
Mar 3, 2014
Using class `test.aria.widgets.form.autocomplete.multiautocomplete.BaseMultiAutoCompleteTestCase`, all MultiAutoComplete testcases have been refactored. Close ariatemplates#982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.