Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default boolan attribute value to false - fix #222 #227

Closed
wants to merge 1 commit into from
Closed

change default boolan attribute value to false - fix #222 #227

wants to merge 1 commit into from

Conversation

b-laporte
Copy link
Member

All is in the title: this PR changes the default value for component boolean attributes to false - which is indeed more intuitive.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1d2f673 on b-laporte:issue222 into a223a0b on ariatemplates:master.

@PK1A
Copy link
Contributor

PK1A commented Jul 7, 2014

LGTM

@benouat
Copy link
Member

benouat commented Jul 15, 2014

Sounds 🆗 to me we can merge it.

@b-laporte b-laporte closed this in 83e2444 Jul 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@b-laporte @coveralls @PK1A @benouat