Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Pratt's parser for expressions in the {log} block #275

Closed
wants to merge 2 commits into from

Conversation

PK1A
Copy link
Contributor

@PK1A PK1A commented Aug 28, 2014

This PR contains 2 commits:

  • 5c10af9 - support for multi-statement expressions
  • 8fe2be8 - the actual switch of expression parsing for the {log} block

Please note that the second commit is actually removing more code than it is adding :-)

@benouat
Copy link
Member

benouat commented Aug 28, 2014

LGTM. Could be merged 👍 (apart my really small comment above)

@PK1A
Copy link
Contributor Author

PK1A commented Sep 1, 2014

Landed as 96c91ad. Thnx for the suggestion @benouat - I'm going to open a separate PR to move to the https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray polyfill for the bullet-proof detection of arrays.

@PK1A PK1A closed this Sep 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants