fix #225 Improve compiler error for attributes with missing quotes #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -191,22 +191,58 @@ HTMLName | |||
| {return first + next.join("");} | |||
|
|
|||
| HTMLAttName | |||
| = first:[a-zA-Z#] next:([a-zA-Z] / [0-9] / "-")* endString:(":" end:([a-zA-Z] / [0-9] / "-")+ {return ":" + end.join("")})? | |||
| = first:[a-zA-Z#] next:([a-zA-Z] / [0-9] / "-" / "_")* endString:(":" end:([a-zA-Z] / [0-9] / "-" / "_")+ {return ":" + end.join("")})? | |||
There was a problem hiding this comment.
Why do we need _ in attributes name ? Sounds weird to me as it is not standard... - would be recommanded wherever you are tempted to use an _
|
This is fine for me ! |
| this._logError(msg, error); | ||
| } | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Just a note, I haven't read the whole commit, but first thing I noticed is that _elementOrComponent becomes a 160-liner after this change. Maybe it would make sense to split some parts of it using helper functions? (either now or in a separate refactor commit).
marclaval
added a commit
to marclaval/hashspace
that referenced
this pull request
Oct 1, 2014
marclaval
added a commit
that referenced
this pull request
Oct 2, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds error messages for wrong attributes of HTML elements and components.
Please have a look at the tests first.
It doesn't takes care of allowing single quotes, @olaf-k is working on this part.