Add from_py_date method to Date to compliment from_py_datetime on _DateTime #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sherbang thanks for spotting this omission and taking the time for this PR 👍 I've started the CI process, which will probably give an error on test coverage. Could you add a simple test in |
|
I also see that The pypy3.8 error is unrelated and due to some pytest issue |
sherbang
force-pushed
the
add_from_py_date
branch
from
b539405
to
676aab5
Compare
sherbang
force-pushed
the
add_from_py_date
branch
from
676aab5
to
ced3e09
Compare
|
I added a test, and fixed the formatting. Thanks! |
|
Thanks @sherbang for your contribution! 🚀 |
ariebovenberg
pushed a commit
that referenced
this pull request
Apr 30, 2024
|
release 0.5.2 is now out with your addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple addition of
Date.from_py_date, matching the API of the datetime classes.Checklist
Release checklist (maintainers only)
pyproject.tomlsrc/whenever/__init__.py