Skip to content

Commit

Permalink
Add support Also Known As titles
Browse files Browse the repository at this point in the history
  • Loading branch information
@ariejan
ariejan committed Jan 31, 2014
1 parent e20ad54 commit febdcae
Show file tree
Hide file tree
Showing 5 changed files with 1,435 additions and 17 deletions.
6 changes: 3 additions & 3 deletions lib/imdb/base.rb
View file
Expand Up @@ -151,7 +151,7 @@ def filming_locations

# Returns alternative titles from imdb_url/releaseinfo
def also_known_as
akas_document.search("#akas tr").map { |aka|
releaseinfo_document.search("#akas tr").map { |aka|
{
:version => aka.search("td:nth-child(1)").text,
:title => aka.search("td:nth-child(2)").text
Expand All @@ -170,8 +170,8 @@ def locations_document
@locations_document ||= Nokogiri::HTML(Imdb::Movie.find_by_id(@id, "locations"))
end

def akas_document
@akas_document ||= Nokogiri::HTML(Imdb::Movie.find_by_id(@id, "releaseinfo"))
def releaseinfo_document
@releaseinfo_document ||= Nokogiri::HTML(Imdb::Movie.find_by_id(@id, "releaseinfo"))
end

# Use HTTParty to fetch the raw HTML for this movie.
Expand Down
24 changes: 12 additions & 12 deletions spec/fixtures/plotsummary
View file
@@ -1,13 +1,13 @@
HTTP/1.1 200 OK
Date: Fri, 31 Jan 2014 10:08:08 GMT
Date: Fri, 31 Jan 2014 11:25:40 GMT
Server: Server
X-Frame-Options: SAMEORIGIN
Content-Type: text/html;charset=UTF-8
Content-Language: en-US
Vary: Accept-Encoding,User-Agent
Set-Cookie: uu=BCYjyTUQu6x2yLfoettgqVT0OkjyhJurUKGHeXaEItnwobv6osmlUhMvGPJrdDdVAjORIiG7HvZa%0D%0AttsHW26O63C4m_yF1-Rye_CLzF4ALT0l284i6eT46k9eHC_WdmyidkcvXnRU_9vjMsuW54q8h8sh%0D%0AOP3wer7FHZWrOCDr85_uOVfS5Dl8K_GuJVyUQL1_PZ_f5uVLSWKCflo8q7sHPl7pSOLYjF6XTcTJ%0D%0ACNpdWSzXI_R-USVDX0Y7jT6NC_A8Lbwfy-CqrzOo4iJ5FgtnAK3pFw%0D%0A; Domain=.imdb.com; Expires=Wed, 18-Feb-2082 13:22:15 GMT; Path=/
Set-Cookie: session-id=000-0000000-0000000; Domain=.imdb.com; Expires=Wed, 18-Feb-2082 13:22:15 GMT; Path=/
Set-Cookie: session-id-time=1548842888; Domain=.imdb.com; Expires=Wed, 18-Feb-2082 13:22:15 GMT; Path=/
Set-Cookie: uu=BCYtrnd-r5Ep5YoFDrX6xKjHRR87f6Q-pL3lu07YvSfNAR7bI4GQewKpefcHoE61xhww3J1slN7A%0D%0AkdhydLQUYJvRR2yRUxwroyENmSPKWjX4y5VBOcCQ85lWEO8FiREt1rXu_zIN3DYV00r6zT24tdTD%0D%0AZ5wqpzdzfqNpiCy3YtMKoq3x-nXSP6dndqqqOBT9WC-rab5z4lW-6iC-svpmze21ZFfy3WOBq64t%0D%0AO6j8L4janQSxRsQT1irJoxmuKL6WeW9n_wePY9Nkx9kA91BXKeBBKg%0D%0A; Domain=.imdb.com; Expires=Wed, 18-Feb-2082 14:39:47 GMT; Path=/
Set-Cookie: session-id=000-0000000-0000000; Domain=.imdb.com; Expires=Wed, 18-Feb-2082 14:39:47 GMT; Path=/
Set-Cookie: session-id-time=1548847540; Domain=.imdb.com; Expires=Wed, 18-Feb-2082 14:39:47 GMT; Path=/
P3P: policyref="http://i.imdb.com/images/p3p.xml",CP="CAO DSP LAW CUR ADM IVAo IVDo CONo OTPo OUR DELi PUBi OTRi BUS PHY ONL UNI PUR FIN COM NAV INT DEM CNT STA HEA PRE LOC GOV OTC "
Transfer-Encoding: chunked

Expand All @@ -32,7 +32,7 @@ xmlns:fb="http://www.facebook.com/2008/fbml">
var ue_sn = "www.imdb.com";
var ue_furl = "fls-na.amazon.com";
var ue_sid = "000-0000000-0000000";
var ue_id = "1B92NE0W07R82T9HW5PC";
var ue_id = "173PREXW0B6WV067R493";
(function(e){var c=e,a={main_scope:"mainscopecsm",q:[],t0:c.ue_t0||+new Date(),d:g};function g(h){return +new Date()-(h?0:a.t0)}function d(h){return function(){a.q.push({n:h,a:arguments,t:a.d()})}}function b(k,j,h){var i={m:k,f:j,l:h,fromOnError:1,args:arguments};c.ueLogError(i);return false}b.skipTrace=1;e.onerror=b;function f(){c.uex("ld")}if(e.addEventListener){e.addEventListener("load",f,false)}else{if(e.attachEvent){e.attachEvent("onload",f)}}a.tag=d("tag");a.log=d("log");a.reset=d("rst");c.ue_csm=c;c.ue=a;c.ueLogError=d("err");c.ues=d("ues");c.uet=d("uet");c.uex=d("uex");c.uet("ue")})(window);(function(e,d){var a=e.ue||{};function c(g){if(!g){return}var f=d.head||d.getElementsByTagName("head")[0]||d.documentElement,h=d.createElement("script");h.async="async";h.src=g;f.insertBefore(h,f.firstChild)}function b(){var k=e.ue_cdn||"z-ecx.images-amazon.com",g=e.ue_cdns||"images-na.ssl-images-amazon.com",j="/images/G/01/csminstrumentation/",h=e.ue_file||"ue-full-ef584a44e8ea58e3d4d928956600a9b6._V1_.js",f,i;if(h.indexOf("NSTRUMENTATION_FIL")>=0){return}if("ue_https" in e){f=e.ue_https}else{f=e.location&&e.location.protocol=="https:"?1:0}i=f?"https://":"http://";i+=f?g:k;i+=j;i+=h;c(i)}if(!e.ue_inline){b()}a.uels=c;e.ue=a})(window,document);
</script>

Expand Down Expand Up @@ -67,10 +67,10 @@ xmlns:fb="http://www.facebook.com/2008/fbml">
<meta name="description" content="Die Hard (1988) on IMDb: New York City Detective John McClane has just arrived in Los Angeles to spend Christmas with his wife. Unfortunatly, it is not going to be a Merry Chr" />
<meta property="og:description" content="Die Hard (1988) on IMDb: New York City Detective John McClane has just arrived in Los Angeles to spend Christmas with his wife. Unfortunatly, it is not going to be a Merry Chr" />
<meta name="keywords" content="Reviews, Showtimes, DVDs, Photos, Message Boards, User Ratings, Synopsis, Trailers, Credits" />
<meta name="request_id" content="1B92NE0W07R82T9HW5PC" />
<meta name="request_id" content="173PREXW0B6WV067R493" />

<script>(function(t){ (t.events = t.events || {})["csm_head_pre_css"] = new Date().getTime(); })(IMDbTimer);</script>
<!-- h=ics-1e-i-193bff60.us-east-1 -->
<!-- h=ics-1d-i-0f44a621.us-east-1 -->

<link rel="stylesheet" type="text/css" href="http://ia.media-imdb.com/images/G/01/imdb/css/collections/title-2125033518._V363851123_.css" />
<!--[if IE]><link rel="stylesheet" type="text/css" href="http://ia.media-imdb.com/images/G/01/imdb/css/collections/ie-1918465287._V354866480_.css" /><![endif]-->
Expand Down Expand Up @@ -266,17 +266,17 @@ onsubmit="(new Image()).src='/rg/SEARCH-BOX/HEADER/images/b.gif?link=/find';"
<li itemprop="headline">
<a href="/news/ni56738656/?ref_=nv_nw_tn_1" > 'Neighbors' with Seth Rogen, 'Space Station 76,' more join SXSW features lineup
</a><br />
<span class="time">14 hours ago</span>
<span class="time">15 hours ago</span>
</li>
<li itemprop="headline">
<a href="/news/ni56738234/?ref_=nv_nw_tn_2" > Oscars: Michael B. Jordan, Kristen Bell to Host Sci-Tech Awards
</a><br />
<span class="time">15 hours ago</span>
<span class="time">16 hours ago</span>
</li>
<li itemprop="headline">
<a href="/news/ni56737830/?ref_=nv_nw_tn_3" > Jerry Seinfeld Sorta Confirms Seinfeld Reunion, Gives Details on Secret Project With Jason Alexander
</a><br />
<span class="time">16 hours ago</span>
<span class="time">17 hours ago</span>
</li>
</ul>
</div>
Expand Down Expand Up @@ -679,7 +679,7 @@ John McClane, a detective with the New York City Police Department, arrives in L
<h4>TV</h4>
<ul class="quicklinks">
<li class="subnav_item_main">
<a href="/title/tt0095016/tvschedule?ref_=ttpl_ql_tv_1" class="link" >TV Schedule</a>
<a href="/title/tt0095016/tvschedule?ref_=ttpl_ql_tv_1" class="link ghost" >TV Schedule</a>
</li>
</ul>

Expand Down Expand Up @@ -1082,7 +1082,7 @@ jQuery(document).ready(function(){
);
</script>

<div id="servertime" time="162"/>
<div id="servertime" time="58"/>



Expand Down

0 comments on commit febdcae

Please sign in to comment.