Encapsulates the API key config access. Refs #1

README.md

@@ -11,8 +11,10 @@ docker build . -t be-challenge-arios
 ### Using environment variables file
 Add keys to `.env` file:
 ```
-FOOTBALL_APIKEY=v4lu3!#
-FOOTBALL_MAX_REQUESTS_PER_MINUTE 10
+FOOTBALL_APIKEY="v4lu3!#"
+FOOTBALL_MAX_REQUESTS_PER_MINUTE=10
+DATABASE_DSN="user:password@host:port/db_name"
+DATABASE_STATUS_QUERY="SELECT 1"
 ```
 
 Make Docker pick them as follows:

pkg/clients/football.go

@@ -69,14 +69,11 @@ type FootballAPIClient interface {
 }
 
 // NewFootballAPIClient creates a new instance of real API client.
-func NewFootballAPIClient(apiKey string) FootballAPIClient {
-	if apiKey == "" {
-		panic("cannot work without a key")
-	}
+func NewFootballAPIClient() FootballAPIClient {
 	return &realAPIClient{
 		baseURL:     BASE_API_URL,
 		client:      client,
-		apiKey:      apiKey,
+		apiKey:      configs.GetFootballAPIKey(),
 		rateLimiter: rateLimiter,
 	}
 }

pkg/clients/football_test.go

@@ -20,21 +20,6 @@ var (
 	apiKey = "abc123"
 )
 
-func TestNewFootballAPIClient(t *testing.T) {
-	t.Run("fails without api key", func(t *testing.T) {
-		defer func() {
-			if r := recover(); r == nil {
-				t.Errorf("The code did not panic")
-			}
-		}()
-		NewFootballAPIClient("")
-	})
-
-	t.Run("ok", func(t *testing.T) {
-		NewFootballAPIClient(apiKey)
-	})
-}
-
 func TestGet(t *testing.T) {
 	t.Run("rate limit applied", func(t *testing.T) {
 		apiContent := loadGoldenFile(t.Name())