Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: HTML5 Audio fallback (for ionic serve/view for example) #2

Closed
eminos opened this issue May 23, 2015 · 13 comments
Closed

Comments

@eminos
Copy link

eminos commented May 23, 2015

The title says it all :)

@arielfaur
Copy link
Owner

I thought about this, but it would clutter the module and increase the codebase all of that for the sake of testing on the dev machine. I guess it is more important to keep the codebase to a minimum and avoid any issues related to performance... just an idea. What do you think?

@eminos
Copy link
Author

eminos commented May 23, 2015

I don't know how much extra code that would be, probably not that much (?). But in that case the best solution would be to have an "plugin module for fallback", maybe with a "fallback" directive, to extend the normal functionality with that fallback (if that's possible at all?) during development.

@arielfaur
Copy link
Owner

I'm just scared this module is already more than 400 lines of code, we'll need minification :)
But I will look into that.

@leonardosalles
Copy link

@arielfaur I think you can separete the module of HTML5 audio, and it can be removed with a cordova hook when we make the build, so you will only need to include the module and the javascript of HTML5 audio, like 'ionicAudio.HTML5Mock' and remove it when it is not on the dev. I can work on this feature and submit a pull request, sounds good for you?

@arielfaur
Copy link
Owner

It was on my roadmap too. But go ahead and submit a pull request!

@leonardosalles
Copy link

Sure, I will implement the way that I mention

@Narayon
Copy link

Narayon commented Jan 18, 2016

The HTML5 Audio implementation is really small. Take a look at this:
goo.gl/SwFVga
Besides that, why should we use the Cordova Media plugin instead of the HTML5 Audio element or even the Web Audio API? Is it more performant? More options?

@arielfaur
Copy link
Owner

@Narayon It's on the TODO list!

@benedyktdryl
Copy link

@arielfaur can I help you with this? You have any concept of "how to implement this"? Just want to create fasade/proxy service which will decide what strategy use for playing audio?

@phishy
Copy link

phishy commented Nov 1, 2016

@Narayon Because on iOS the HTML5 Audio element doesn't work in the background without the cordova media plugin.

@arielfaur The description of this repo is misleading. It says it uses HTML audio as fallback. I can't see any mention it, unless I'm missing it?

@arielfaur
Copy link
Owner

@phishy The HTML audio fallback is for v2! Sorry if the description is misleading. The v2 is on a separate branch though.

arielfaur pushed a commit that referenced this issue Mar 3, 2017
@tbergeron
Copy link

Inactive issue? Can we close this?
This is already working in v2 and v3 if I'm not mistaken.

@arielfaur
Copy link
Owner

@tbergeron Yes, let's close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants