Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back pointer events on mobile after fast repetitive touches #164

Merged
merged 1 commit into from
Apr 2, 2015

Conversation

bez4pieci
Copy link
Contributor

Fixes #145

@arielsalminen
Copy link
Owner

@bez4pieci Thanks for looking into this! I’ll test this soon and do a merge tomorrow if everything is working :)

@arielsalminen
Copy link
Owner

@bez4pieci I’ve been looking into this today and it seems like I can further simplify the whole toggle logic quite a lot. I have a new version ready with your changes merged, but I still want to test it tomorrow with few more devices before pushing a new version out.

@arielsalminen arielsalminen merged commit 99bc5d7 into arielsalminen:master Apr 2, 2015
@bez4pieci
Copy link
Contributor Author

@viljamis, great to hear 👍! would be great to avoid adding/removing classes to <body> altogether!

@arielsalminen
Copy link
Owner

@bez4pieci Turns out I could actually remove the whole pointer-events functionality yesterday evening completely while still making the ghost click issue to not happen anymore on Android 2.3 and under. Just pushed out a new version!

So no more classes added to body or extra CSS for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable-pointer-events not removed after fast touches
2 participants