Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method and option for multiple menus #37

Closed
wants to merge 1 commit into from

Conversation

juliankrispel
Copy link

This has been mentioned in issue #32 and I needed it for my own work.

Cheers!

@jbernal
Copy link

jbernal commented May 24, 2013

Hi juliank - Any progress on having functionality for multiple responsive-nav instances?

@juliankrispel
Copy link
Author

Hello @jbernal why don't you ask the plugin author @viljamis ? I can't accept/comment on pull requests in his stead

@arielsalminen
Copy link
Owner

@juliankrispel This doesn't seem to calculate the height correctly for multiple menus. For me it returns height always as "undefined" if the new option is used, which then breaks the transition.

Another issue with the pull, but not that big one, is that it doesn't follow the guidelines which can be found here: https://github.com/viljamis/responsive-nav.js/blob/master/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants