Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate pages & URLs for all nav items to allow richer documentation of components #63

Closed
arielsalminen opened this issue Apr 2, 2018 · 10 comments

Comments

@arielsalminen
Copy link
Owner

arielsalminen commented Apr 2, 2018

“One component per page” functionality is now supported in Vue Styleguidist and I want to bring it into Vue Design System rather soon as well. It does require a couple of things:

  • Updating Vue Styleguidist NPM dependency
  • Changing the formatting of the Vue Styleguidist config (mostly template option)
  • Edits to the way sidenav highlights items (has to support highlighting of sub items as well)
  • Edits to the overall styles of docs (they need to better support separate pages)
  • Reordering sections/components.
  • Richer example content that better supports separate pages and one component per page. Could include things like:
    • Best practices
    • Content guidelines
    • Usage do’s & don’ts

Looking for input from the community at the moment. Seem my second comment below.

@arielsalminen arielsalminen added this to the 2.1.0 milestone Apr 2, 2018
@arielsalminen arielsalminen self-assigned this Apr 2, 2018
@arielsalminen arielsalminen changed the title Separate pages & URLs for all nav items to allow richer docs per component Separate pages & URLs for all nav items to allow richer documentation of components Apr 2, 2018
@arielsalminen
Copy link
Owner Author

arielsalminen commented Apr 2, 2018

I’m interested to hear people’s opinions about this before working on it further:

Would you prefer that every component is in a separate URL, or the current model where different sections live in separate URLs?

Example of how it works currently can be seen on the website (sections have separate URLs): http://vueds.com/example/

The problem with the current model is that it can get a bit heavy when the system gets bigger and when there are more components. The other side is that it doesn’t allow a lot of documentation per component.

I guess the best solution would be to have this as an option, but Styleguidist doesn’t currently support that so it’d have to be a fork (for the time being at least). That’s something I’d want to avoid as it will make the process of updating things much harder.

@arielsalminen
Copy link
Owner Author

arielsalminen commented Apr 2, 2018

Related pull/branch is here: #64 , but there’s nothing there yet

@tuuukka
Copy link

tuuukka commented Apr 3, 2018

+1 to supporting components to have separate URLs. When the design system grows bigger, listing the detailed view of all components makes the style guide slow to load and harder to browse. It's also quite useful to be able to link a specific component to team members.

On the flip side easy discovery and glanceability is also quite important in the component listing. Maybe the ideal scenario would be to have control over the level of detail exposed in the listing. For small design systems displaying the full component documentation directly in the listing view might make sense. For larger systems you might however only show the key details and expose the full documentation only when drilling down into the individual component view.

@arielsalminen
Copy link
Owner Author

Related discussion/issue in Vue Styleguidist: vue-styleguidist/vue-styleguidist#113

@arielsalminen
Copy link
Owner Author

Related issue in React Styleguidist: styleguidist/react-styleguidist#892

@arielsalminen
Copy link
Owner Author

@tuuukka It looks like this is most likely going to be behind an option at some point, so you can decide how much separation is needed. There’s a related pull request in React Styleguidist, thanks to @rafaesc: styleguidist/react-styleguidist#941

@rafaesc
Copy link
Contributor

rafaesc commented May 25, 2018

A new PR related with this issue

styleguidist/react-styleguidist#993

@arielsalminen
Copy link
Owner Author

@rafaesc Looks very useful!

@arielsalminen arielsalminen modified the milestones: 2.2.0, 3.0.0 May 30, 2018
@arielsalminen
Copy link
Owner Author

Part of #82

@arielsalminen
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants