[QA checks] tolerate connector without dockerfile (airbytehq#30467)

airbyte-ci/connectors/connector_ops/connector_ops/qa_checks.py

@@ -5,7 +5,7 @@
 
 import sys
 from pathlib import Path
-from typing import Iterable, Optional, Set, Tuple
+from typing import Callable, Iterable, Optional, Set, Tuple
 
 from connector_ops.utils import Connector, ConnectorLanguage
 from pydash.objects import get
@@ -14,7 +14,7 @@
 def check_migration_guide(connector: Connector) -> bool:
     """Check if a migration guide is available for the connector if a breaking change was introduced."""
 
-    breaking_changes = get(connector.metadata, f"releases.breakingChanges")
+    breaking_changes = get(connector.metadata, "releases.breakingChanges")
     if not breaking_changes:
         return True
 
@@ -27,7 +27,7 @@ def check_migration_guide(connector: Connector) -> bool:
 
     # Check that the migration guide begins with # {connector name} Migration Guide
     expected_title = f"# {connector.name_from_metadata} Migration Guide"
-    expected_version_header_start = f"## Upgrading to "
+    expected_version_header_start = "## Upgrading to "
     with open(migration_guide_file_path) as f:
         first_line = f.readline().strip()
         if not first_line == expected_title:
@@ -55,7 +55,7 @@ def check_migration_guide(connector: Connector) -> bool:
 
         if ordered_breaking_changes != ordered_heading_versions:
             print(f"Migration guide file for {connector.name} has incorrect version headings.")
-            print(f"Check for missing, extra, or misordered headings, or headers with typos.")
+            print("Check for missing, extra, or misordered headings, or headers with typos.")
             print(f"Expected headings: {ordered_expected_headings}")
             return False
 
@@ -242,7 +242,7 @@ def check_metadata_version_matches_dockerfile_label(connector: Connector) -> boo
     return version_in_dockerfile == connector.version
 
 
-QA_CHECKS = [
+DEFAULT_QA_CHECKS = (
     check_documentation_file_exists,
     check_migration_guide,
     # Disabling the following check because it's likely to not pass on a lot of connectors.
@@ -254,8 +254,13 @@ def check_metadata_version_matches_dockerfile_label(connector: Connector) -> boo
     # https://github.com/airbytehq/airbyte/issues/21606
     check_connector_https_url_only,
     check_connector_has_no_critical_vulnerabilities,
-    check_metadata_version_matches_dockerfile_label,
-]
+)
+
+
+def get_qa_checks_to_run(connector: Connector) -> Tuple[Callable]:
+    if connector.has_dockerfile:
+        return DEFAULT_QA_CHECKS + (check_metadata_version_matches_dockerfile_label,)
+    return DEFAULT_QA_CHECKS
 
 
 def remove_strict_encrypt_suffix(connector_technical_name: str) -> str:
@@ -289,7 +294,7 @@ def run_qa_checks():
     connector_technical_name = remove_strict_encrypt_suffix(connector_technical_name)
     connector = Connector(connector_technical_name)
     print(f"Running QA checks for {connector_technical_name}:{connector.version}")
-    qa_check_results = {qa_check.__name__: qa_check(connector) for qa_check in QA_CHECKS}
+    qa_check_results = {qa_check.__name__: qa_check(connector) for qa_check in get_qa_checks_to_run(connector)}
     if not all(qa_check_results.values()):
         print(f"QA checks failed for {connector_technical_name}:{connector.version}:")
         for check_name, check_result in qa_check_results.items():

airbyte-ci/connectors/connector_ops/connector_ops/utils.py

@@ -299,6 +299,10 @@ def icon_path(self) -> Path:
     def code_directory(self) -> Path:
         return Path(f"./airbyte-integrations/connectors/{self.technical_name}")
 
+    @property
+    def has_dockerfile(self) -> bool:
+        return (self.code_directory / "Dockerfile").is_file()
+
     @property
     def metadata_file_path(self) -> Path:
         return self.code_directory / METADATA_FILE_NAME
@@ -321,20 +325,19 @@ def language(self) -> ConnectorLanguage:
         return None
 
     @property
-    def version(self) -> str:
+    def version(self) -> Optional[str]:
         if self.metadata is None:
             return self.version_in_dockerfile_label
         return self.metadata["dockerImageTag"]
 
     @property
     def version_in_dockerfile_label(self) -> Optional[str]:
-        try:
-            with open(self.code_directory / "Dockerfile") as f:
-                for line in f:
-                    if "io.airbyte.version" in line:
-                        return line.split("=")[1].strip()
-        except FileNotFoundError:
+        if not self.has_dockerfile:
             return None
+        with open(self.code_directory / "Dockerfile") as f:
+            for line in f:
+                if "io.airbyte.version" in line:
+                    return line.split("=")[1].strip()
         raise ConnectorVersionNotFound(
             """
             Could not find the connector version from its Dockerfile.