fix type issue

arif98741 · Sep 28, 2022 · c6ad313 · c6ad313
1 parent b23741b
commit c6ad313
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/Job/SendSmsJob.php b/src/Job/SendSmsJob.php
@@ -36,19 +36,18 @@ public function __construct(array $jobDetails)
     /**
      * Execute the job.
      *
-     * @return ResponseInterface
-     * @throws GuzzleException
+     * @return ResponseInterface|null
+     * @throws GuzzleException|JsonException
      */
     public function handle()
     {
 
-
         if ($this->jobDetails['method'] == 'post') {
             return $this->postMethodHandler();
 
-        } else {
-            return $this->getMethodHandler();
         }
+
+        return $this->getMethodHandler();
     }
 
     /**
@@ -106,7 +105,7 @@ private function getMethodHandler()
             $log = [
                 'provider' => $this->jobDetails['requestUrl'],
                 'request_json' => json_encode($this->jobDetails['query'], JSON_THROW_ON_ERROR),
-                'response_json' => json_encode($e->getMessage()),
+                'response_json' => json_encode($e->getMessage(), JSON_THROW_ON_ERROR),
             ];
         }
 

diff --git a/src/Request.php b/src/Request.php
@@ -48,7 +48,7 @@ public function __construct($requestUrl, array $query, bool $queue = false, arra
      * @throws RenderException
      */
 
-    public function get(bool $verify = false, $timeout = 10.0)
+    public function get(bool $verify = false, float $timeout = 10.0)
     {
         $client = new Client([
             'base_uri' => $this->requestUrl,
@@ -206,7 +206,7 @@ public function setFormParams(array $form_params): Request
      * @param mixed $timeout
      * @return array
      */
-    private function optionsGetRequest(bool $verify, mixed $timeout): array
+    private function optionsGetRequest(bool $verify, float $timeout): array
     {
         $options = [
             'requestUrl' => $this->requestUrl,