lint@v1 action requires dir-name even though it should be optional

[till]

Seems like it's fixed in master, but not relased?

action.yml says required false:
https://github.com/ariga/atlas-action/blob/master/migrate/lint/action.yml#L12-L14

[till]

It seems like the error is not in the action's direct code, but in the ariga-atlas:
https://github.com/ariga/atlas-action/blob/master/atlasaction/action.go#L93

It it save to assume that the linting "only" works with an account on atlas.io? I wasn't aware of that.

[rotemtam]

The current lint action requires an Atlas Cloud token, yes. You can always cook your own by manually running atlas migrate lint if that doesn't work for you 🙏

[till]

@rotemtam makes sense, I think the action.yml should be fixed then to make it more obvious that the inputs are required.

[masseelch]

I think the action.yml should be fixed then to make it more obvious that the inputs are required

The values can be given to atlas by using an atlas.hcl configuration file. Therefore, they can not be required here.

https://github.com/ariga/atlas-action#inputs-2

[clarkedb]

The current lint action requires an Atlas Cloud token, yes. You can always cook your own by manually running atlas migrate lint if that doesn't work for you 🙏

@rotemtam Is there a specific reason that the action has been modified to only be useful to those using Atlas Cloud? Pre-v1 this worked for people not using Atlas Cloud.

[rotemtam]

hey @clarkedb

Thanks for reaching out. Great question - here's the gist of it:

Last October, we did a full revamp of the whole Atlas GH Actions codebase. As part of that change we deprecated the old atlas-action which was written in TypeScript and longer seriously maintained.

As you probably know, Atlas is backed by Ariga, a commercial company. Our team is very small and so we try to be laser-focused on work that will bring Atlas to sustainable success. In other words, the less we do, the better we can do it, and the more likely we are to build something that sticks for the very long run. For this reason, we also deprecated the old acions on that same occasion.

Regarding the action CI flow, we think the cloud-connected flow is much better and has critical technical capabilities like detecting Non Linear Change that are dependent on having external state available for calculations.

If for any reason you cannot use the free Atlas Cloud tier, you can always simply call atlas migrate lint from any normal GitHub Actions Workflow and get a similar result.

I hope this answers your question