Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate/lint: dir-name and dev-url are required for lint/push #114

Closed
wants to merge 1 commit into from
Closed

migrate/lint: dir-name and dev-url are required for lint/push #114

wants to merge 1 commit into from

Conversation

masseelch
Copy link
Member

Fix #112

@masseelch masseelch requested review from rotemtam, dorav and a team January 11, 2024 08:46
@github-actions GitHub Actions
Copy link

Atlas Lint Report

Analyzed migrations

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks
Migrations automatically reviewed by Atlas

@github-actions GitHub Actions
Copy link

Atlas Lint Report

Analyzed migrations2

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks
Migrations automatically reviewed by Atlas

@github-actions GitHub Actions
Copy link

atlas migrate lint results:

Status Step Link
1 new migration file detected  
ERD and Visual Diff generated View Visualization
No issues found. Full Report

Migrations automatically reviewed with Atlas

@github-actions GitHub Actions
Copy link

atlas migrate lint results:

Status Step Link
1 new migration file detected  
ERD and Visual Diff generated View Visualization
1 error found Full Report

Migrations automatically reviewed with Atlas

rotemtam
rotemtam requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@rotemtam rotemtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values can be provided via a project config file. So in effect, they are not required.

@masseelch masseelch closed this Jan 11, 2024
@masseelch masseelch deleted the j/required-attributes branch January 11, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemtam rotemtam rotemtam requested changes

@dorav dorav Awaiting requested review from dorav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lint@v1 action requires dir-name even though it should be optional
2 participants
@masseelch @rotemtam